255537 - Patching to add a parameter breaks editparams.cgi

Status: RESOLVED WONTFIX

(Bugzilla :: Administration, task)

Description

[Nick Barnes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.8
Build Identifier: 

As part of the P4DTI integration between Perforce and Bugzilla, we provide a
patch to Bugzilla.  Among other things, this patch adds a boolean parameter to
Bugzilla, called "p4dti", by adding a few lines to defparams.pl.  The P4DTI
installation instructions then instruct the administrator to use editparams.cgi
to turn this parameter on.
Since 2.17.x, this procedure doesn't work because editparams.cgi says "No value
for param p4dti (try running checksetup.pl again) at Bugzilla/Config.pm line
161.".  In other words, editparams.cgi requires every parameter to have a
current value in data/params.
Running checksetup.pl again does fix this problem, and I will update the P4DTI
installation instructions to include that step, but it would be better if
editparams.cgi handled this situation without an error (e.g. by giving the
default value to any unset parameter).

Reproducible: Always
Steps to Reproduce:
1. edit defparams.pl to add a new parameter.
2. run editparams.cgi.

Actual Results:  
"No value for param p4dti (try running checksetup.pl again) at
Bugzilla/Config.pm line 161."

Expected Results:  
Maybe "unset parameter p4dti detected, setting to default value (off)".

Comment 1

[Dave Miller [:justdave]]

That was done on purpose because usually when a param that didn't previously
exist magically shows up, it means a patch has been applied, and usually patches
need to have setup done (which checksetup.pl does).  CVS also has a habit of
screwing with file permissions when you do an update, and checksetup.pl is
needed to set the permissions back how they go.  As you noted, the error message
you get is self-explanatory.