255877 - right-clicking an expanded bookmarks folder shows "Collapse(X)"

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Steffen Wilberg]

In the bookmarks sidebar or bookmarks manager, right-click an expanded (open)
folder. The first menu item is labelled "Collapse(X)".

Bug 245984 introduced accesskeys, but failed to assign the "C" accesskey to
collapsed folders. Patch coming up.

Comment 1

[Steffen Wilberg]

Attachment: assign the accesskey as well

Also replace the bogus switch by an if clause.

Comment 2

[Steffen Wilberg]

Comment on attachment 156341 [details] [diff] [review]
assign the accesskey as well

Mike, since you reviewed the bug 245984, which introduced this, would you mind
looking at this?

Comment 3

[Jesse Ruderman]

Bug 243235 (remove expand/collapse context menu items) is plussed for 1.0.  How
about fixing that instead?

Comment 4

[Steffen Wilberg]

The patch for that one hides Expand/Collapse from the bookmarks menu and folders
on the bookmarks toolbar, see bug 243235 comment 17.
Whether it should be removed from the bookmarks manager and the sidebar as well
is still under discussion, see comment 14 and 18 in that bug.

That one should be fixed by 1.0, while this one looks so broken that it should
be fixed immediately.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 156341 [details] [diff] [review]
assign the accesskey as well

argh.

Comment 6

[chris hofmann]

Comment on attachment 156341 [details] [diff] [review]
assign the accesskey as well

let's get it landed quickly

Comment 7

[Steffen Wilberg]

Checked in br & trunk 2004-08-20 03:26.

Comment 8

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change