Closed
Bug 255934
Opened 20 years ago
Closed 20 years ago
urlbar favicon not updated on tab switch if site has favicon.ico instead of link
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file)
|
2.73 KB,
patch
|
bugs
:
approval-aviary+
|
Details | Diff | Splinter Review |
(There might already be bug filed for this, but I can't find it in 15-20 min of searching, so.) If a favicon is loaded from favicon.ico instead of a link, the favicon in the urlbar doesn't come back from the generic one after switching away from the tab because we don't set the mIcon attribute on the listener. (see comment #14 in bug 181872 -- this doesn't fix 181872 though.)
|
Assignee | |
Comment 1•20 years ago
|
||
Patch.
|
|
Assignee | |
Updated•20 years ago
|
Attachment #156380 -
Flags: approval-aviary?
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•20 years ago
|
||
Comment on attachment 156380 [details] [diff] [review] favicons-listener-fix-0.patch a=ben@mozilla.org
Attachment #156380 -
Flags: approval-aviary? → approval-aviary+
|
|
Assignee | |
Comment 3•20 years ago
|
||
in on aviary, needs trunk checkin
|
|
Assignee | |
Updated•20 years ago
|
Keywords: fixed-aviary1.0
|
||
Comment 4•20 years ago
|
||
This has sat around since August, can it go to the trunk?
Flags: blocking-aviary1.1?
|
||
Comment 5•20 years ago
|
||
Fixed on trunk by the branch landing.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Flags: blocking-aviary1.1?
|
||
Comment 6•18 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•