256007 - Help Viewer's left pane is empty

Status: VERIFIED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Steffen Wilberg]

Open Help->Help Contents and notice that the left pane is empty.
Confirmed on Linux and Windows.

Maybe a regression from vlad's checkin starting 08/17/2004 19:00 PDT.

Comment 1

[Steffen Wilberg]

Regressed between 08/17 and 08/18.

This is a blocker for work on Help content.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

There is something with the way help deals with the datasources for the side
pane that is interacting badly with the inference data source bits.  If I set an
'infer="forward-proxy"' on the help elements that have templates, the content
gets built correctly; however, many other places in ffox that don't use
inference (e.g. history sidebar, various menus, etc.) work fine.

Effectively, if the infer attribute isn't there, the template builder should
behave exactly as it did before, so I'm not sure what's going on.  I'll keep
tracking it down.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: agg-fix-1.patch

The template builder didn't correctly pick up the newly created Composite DS if
the datasources were reloaded, which the help sidebar does (as it dynamically
adds them).  Attached patch fixes

Comment 4

[Steffen Wilberg]

Thanks vlad, works fine!

Comment 5

[amano]

What is missing to get this checked in?

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #5)
> What is missing to get this checked in?

aviary approval.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 156464 [details] [diff] [review]
agg-fix-1.patch

a=asa

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in, thanks

Comment 9

[Mike Kaply [:mkaply]]

vlad:

Were the changes that caused this regression checked into the trunk or 1.7?

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Neither; I'll be checking this into the trunk (including this patch) today, however.

Comment 11

[Mike Kaply [:mkaply]]

Do you see any reason why this patch would be useful on 1.7?

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Not this particular patch by itself; if the aggregation patch from bug 235665
gets taken for 1.7, then this will come along with it.

Comment 13

[Tracy Walker [:tracy]]

verified with Firefox Branch 2004-09-10-08-0.9