256101 - Properties dialog does not close on OK

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

1. Right click on a personal toolbar item
2. Choose "Properties..."
3. Change the name of a bookmark
4. Click "OK"

Expected results:
- bookmark renamed and properties window closes

Actual results:
- bookmark renamed but properties window doesn't close

Comment 1

[Bill Mason]

*** Bug 256110 has been marked as a duplicate of this bug. ***

Comment 2

[Peter van der Woude [:Peter6]]

This goes for more OK buttons in Bookmarks

repro:
1. Bookmarks -> Manage Bookmarks
2. New Folder , click OK

The prop box won't close, the folder is made though

btw:
( 1. Bookmarks -> Manage Bookmarks )
( 2. New Bookmark , click OK, does work normal )

Comment 3

[Benjamin Smedberg]

*** Bug 256163 has been marked as a duplicate of this bug. ***

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: bm-props-fix-0.patch

This wasn't supposed to get checked in with the patch it went in with, but
here's a fix for it =/

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: bm-props-fix-0.patch (the right one)

Wrong file

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 156522 [details] [diff] [review]
bm-props-fix-0.patch (the right one)

a=asa

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

in, thanks

Comment 8

[Bill Mason]

*** Bug 256187 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change