Closed
Bug 256640
Opened 20 years ago
Closed 20 years ago
Make document.all act as a collection (document.getElementsByTagName("*"))
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
References
Details
(Keywords: fixed-aviary1.0, fixed1.7.5)
Attachments
(1 file)
15.41 KB,
patch
|
brendan
:
review+
brendan
:
superreview+
brendan
:
approval-aviary+
brendan
:
approval1.7.5+
|
Details | Diff | Splinter Review |
IE lets developers do document.all[2] to access the second element in the document. We can do the same, and doing that would fix yet a few more compatibility problems... Patch coming up.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #156833 -
Flags: superreview?(brendan)
Attachment #156833 -
Flags: review?(brendan)
Comment 2•20 years ago
|
||
Comment on attachment 156833 [details] [diff] [review] Make document.all a collection too Fix the s/chaper/cheaper/typo, and tighten up the CallToGetPropMapper logic to check whether the class of its |obj| param is sHTMLDocumentAllClass, and r+sr=me. Pre-approving for aviary and 1.7.3 based on bclary's thumbs-up. /be
Attachment #156833 -
Flags: superreview?(brendan)
Attachment #156833 -
Flags: superreview+
Attachment #156833 -
Flags: review?(brendan)
Attachment #156833 -
Flags: review+
Attachment #156833 -
Flags: approval1.7.3+
Attachment #156833 -
Flags: approval-aviary+
Comment 3•20 years ago
|
||
s/second/third/ in comment 0 "document.all[2] to access the second element...." /be
Assignee | ||
Comment 4•20 years ago
|
||
Fixed on trunk and aviary branch.
Comment 5•20 years ago
|
||
This didn't go onto the aviary branch according to bonsai...
Assignee | ||
Comment 6•20 years ago
|
||
Thanks, good catch. I had a typo in my checkin command that I missed, so it hadn't gone in yet. Duh Fixed on the aviary branch now.
Assignee | ||
Comment 7•20 years ago
|
||
*** Bug 253451 has been marked as a duplicate of this bug. ***
Updated•14 years ago
|
Assignee: general → jst
QA Contact: ian → general
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•