256663 - old default plugin/new plugin placeholder can both appear on same page

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[(not currently active) Ted Mielczarek]

At the given URL, one out of many EMBED tags shows the old default plugin, and
pops up the plugin message, while the rest show the new plugin placeholder.  The
plugin info bar is also shown.  Tested with a new profile on my linux CVS build
from today.

The EMBED in question looks like this:
<embed src='/images/upload/T1064366333nbc.swf' width=124 height=45>
It's the one on the left, below "Virtual NYC" and above "ASK NewYork.com".

The ones that show the new placeholder look like this:
<embed src="/images/m_1.swf" quality=high
pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash"
type="application/x-shockwave-flash" width="95" height="85">

Related to bug 244125 , maybe blocking?

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040821 Firefox/0.9.1+

about:buildconfig
Build platform
target
i686-pc-linux-gnu

Build tools
Compiler 	Version 	Compiler flags
gcc 	gcc version 3.3.4 (Debian 1:3.3.4-3) 	-Wall -W -Wno-unused -Wpointer-arith
-Wcast-align -Wno-long-long -pedantic -pthread -pipe
c++ 	gcc version 3.3.4 (Debian 1:3.3.4-3) 	-fno-rtti -fno-exceptions -Wall
-Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic
-fshort-wchar -pthread -pipe -I/usr/X11R6/include

Configure arguments
--disable-ldap --disable-mailnews
--enable-extensions=cookie,xml-rpc,xmlextras,pref,transformiix,universalchardet,webservices,inspector,gnomevfs,negotiateauth
--enable-crypto --disable-composer --enable-single-profile
--disable-profilesharing --disable-tests --disable-debug --enable-optimize
--enable-xft --enable-default-toolkit=gtk2

Comment 1

[u88484]

I can confirm this on (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2)
Gecko/20040825 Firefox/0.9.1+) might be same for all OSes if not there is a bug
filed for XP also http://bugzilla.mozilla.org/show_bug.cgi?id=256956

Comment 2

[Johnny Stenback (:jst)]

*** Bug 256956 has been marked as a duplicate of this bug. ***

Comment 3

[Johnny Stenback (:jst)]

Yeah, this is XP.

So here's what's happening. The current Firefox builds are in an odd state in
that the new default plugin replacement is checked in, but it's not fully
enabled yet. So what *should* be happening is that you should *only* see the
good ol' default plugin, and never the new one, unless you enable it. That's a
problem, as we'll want to be able to disable this completely if something goes
really wrong. I've got a patch for doing that that I'll attach shortly.

Comment 4

[(not currently active) Ted Mielczarek]

Updating summary and blocking

Comment 5

[Johnny Stenback (:jst)]

Attachment: Duh, wrong file.

This should've been done from the start, I just missed this...

Comment 6

[Johnny Stenback (:jst)]

Attachment: Never show the default plugin replacement if the default plugin is still enabled.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 157081 [details] [diff] [review]
Never show the default plugin replacement if the default plugin is still enabled.

a=asa for avaiary landing.

Comment 8

[Johnny Stenback (:jst)]

Fixed on aviary branch. Marking FIXED.

Comment 9

[u88484]

the patch worked but should the icon have been stretched like how it is on this
page? http://zed.cbc.ca/go.ZeD?CONTENT_ID=2365&mediaSize=double&page=media-viewer
on other pages i've tried the patch works and the above link is the only one i
could find that the icon was stretched.

Comment 10

[Oakwine]

(In reply to comment #9)
> the patch worked but should the icon have been stretched like how it is on this
> page? http://zed.cbc.ca/go.ZeD?CONTENT_ID=2365&mediaSize=double&page=media-viewer
> on other pages i've tried the patch works and the above link is the only one i
> could find that the icon was stretched.

I have the required plugin, and the video on that site is also stretched (too
thin vertically).  Also sqiushed on IE.

Comment 11

[u88484]

before the patch the icon on the bottom placeholder was the new icon and it was
centerd and not stretched. Now after the patch the icon is the old icon (which
is should be) but its stretched.

Comment 12

[Johnny Stenback (:jst)]

The default plugin (the old one) apparently has some streatching problems on
this page. I tested this with an old build w/o any of the recent plugin changes,
and I see the same problem there. So that's a separate bug that you can file if
you want to, but since the default plugin is going away, I doubt anyone will
invest time in fixing it.

Comment 13

[u88484]

No use in filing a bug report for a bug that wasn't present when the plugin
manager was partly implement and the bug wasn't present. I'll wait until the
plugin manager is fully implemented and see if the problem still exists. 

Comment 14

[Asaf Romano (gone)]

Since this checkin, i don't see the new plugin manager anymore.

Comment 15

[u88484]

Asaf thats what was supposed to happen. The patch was supposed to disable the
plug-in manager

Comment 16

[(not currently active) Ted Mielczarek]

Verified on branch.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040830