Closed
Bug 256988
Opened 20 years ago
Closed 20 years ago
firefox pkg-config files reference mozilla-xpcom and mozilla-nspr
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: shaver)
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file, 1 obsolete file)
5.14 KB,
patch
|
shaver
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040824 Firefox/0.9.1+ The pkg-config files generated in a firefox build reference mozilla-xpcom and mozilla-nspr, but the .pc files generated are named firefox-xpcom.pc and firefox-nspr.pc. Reproducible: Always Steps to Reproduce: 1. pkg-config --libs firefox-gtkmozembed Actual Results: Package 'Mozilla Gtk Embedding Widget' requires 'mozilla-xpcom = 0.9.1+' but version of XPCOM is 1.7.2 (or whatever mozilla build version you have) Expected Results: -L/opt/firefox/lib/firefox-0.9.1+ -lgtkembedmoz -lxpcom -lplds4 -lplc4 -lnspr4 -lpthread -ldl
Reporter | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
Yeah, let's get this in. In a more-ideal world, we'd produce mozilla-xpcom and mozilla-nspr and mozilla-nss from the firefox build as well, and reference them, but I think that doing that sort of thing now will make firefox-devel and mozilla-devel conflict badly. xulrunner and libxul.so are the real solution here, so this is a 1.0-grade fix in my opinion.
Assignee: bryner → shaver
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 157051 [details] [diff] [review] proposed fix r=shaver, a=shaver for aviary. I'll commit before PR1. Thanks.
Attachment #157051 -
Flags: review+
Attachment #157051 -
Flags: approval-aviary+
Reporter | ||
Comment 4•20 years ago
|
||
(In reply to comment #3) > r=shaver, a=shaver for aviary. I'll commit before PR1. Thanks. PR1 is already out but this is not yet fixed; can this be committed now, please? Thanks.
Assignee | ||
Comment 5•20 years ago
|
||
Fixed on the branch. Sorry for the delay, I suck.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Keywords: fixed-aviary1.0
Reporter | ||
Comment 6•19 years ago
|
||
Apparently this patch was never checked in on trunk. This bug means you cannot use the firefox-*.pc pkg-config files; so the patch is no-risk and fixes a important bug.
Attachment #157051 -
Attachment is obsolete: true
Attachment #181537 -
Flags: approval-aviary1.1a?
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 181537 [details] [diff] [review] rediff'd patch to apply cleanly to trunk Yeah, a=shaver.
Attachment #181537 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Comment 8•19 years ago
|
||
checked in on trunk.
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•