256988 - firefox pkg-config files reference mozilla-xpcom and mozilla-nspr

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040824 Firefox/0.9.1+

The pkg-config files generated in a firefox build reference mozilla-xpcom and
mozilla-nspr, but the .pc files generated are named firefox-xpcom.pc and
firefox-nspr.pc.

Reproducible: Always
Steps to Reproduce:
1. pkg-config --libs firefox-gtkmozembed

Actual Results:  
Package 'Mozilla Gtk Embedding Widget' requires 'mozilla-xpcom = 0.9.1+' but
version of XPCOM is 1.7.2
(or whatever mozilla build version you have)

Expected Results:  
-L/opt/firefox/lib/firefox-0.9.1+ -lgtkembedmoz -lxpcom -lplds4 -lplc4 -lnspr4
-lpthread -ldl

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed fix

Comment 2

[Mike Shaver (:shaver emeritus)]

Yeah, let's get this in.

In a more-ideal world, we'd produce mozilla-xpcom and mozilla-nspr and
mozilla-nss from the firefox build as well, and reference them, but I think that
doing that sort of thing now will make firefox-devel and mozilla-devel conflict
badly.

xulrunner and libxul.so are the real solution here, so this is a 1.0-grade fix
in my opinion.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 157051 [details] [diff] [review]
proposed fix

r=shaver, a=shaver for aviary.	I'll commit before PR1.  Thanks.

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

(In reply to comment #3)
> r=shaver, a=shaver for aviary.	I'll commit before PR1.  Thanks.

PR1 is already out but this is not yet fixed; can this be committed now, please?
Thanks.

Comment 5

[Mike Shaver (:shaver emeritus)]

Fixed on the branch.  Sorry for the delay, I suck.

Comment 6

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: rediff'd patch to apply cleanly to trunk

Apparently this patch was never checked in on trunk. This bug means you cannot
use the firefox-*.pc pkg-config files; so the patch is no-risk and fixes a
important bug.

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 181537 [details] [diff] [review]
rediff'd patch to apply cleanly to trunk

Yeah, a=shaver.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on trunk.