257075 - [keyboard] User can't select mails which are not next to.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Nian Liu(n/a in a long time)]

Steps to reproduce:
1. Launch Mozilla-mail.
2. Ensure there is an available mail account and some mails in Inbox folder.
3. Press Tab to move focus to mail message.
4. Press Arrow to select one message.
5. Press and hold Ctrl, move focus up or down by Arrow, select another one
message not next to the one which is selected in step4.

Expected result:
User can select some mails which are not next to.

Actual result:
User can not select more than two mails which are not next to.

Comment 1

[Nian Liu(n/a in a long time)]

Attachment: patch

Comment 2

[Aaron Leventhal]

Comment on attachment 157113 [details] [diff] [review]
patch

Nian, I don't understand the bug report, so I can't say if the patch is
correct. What is Ctrl+arrow supposed to do?

Also, what does this mean?
+	    //not do unselect to keep consistent with windows

The behavior in Windows is:
Up/down - move focus and set selection to only the focused item
Shift+up/Shift+down - move focus and extend selection to focused item
Ctrl+up/Ctrl+down - move focus but don't change selection
Ctrl+space - toggle whether focused item is selected
Shift+space - extend selection to the focused item
Space - select the focused item (this won't work in mail, because space bar
means read next screenful of mail, going to next message if necessary).

What behavior are you implementing here? Instead of having an attribute called
'ctrlSelectMode' could you choose a name that is more descriptive of the
behavior?

Comment 3

[Nian Liu(n/a in a long time)]

what i implemented is the "ctrl" select behavior with keyboard support(that's
the reason why i named it ctrlSelectMode).

and ctrl+space is not toggle current item in both window and linux. it's the
short key to switch input method. space is the key to toggle current item if
user uses ctrl+up/down to navigate to it.

and for space behavior in mail, i think if user use multiple selection, he/she
should not care about the content of the mail. if not multiple selection, space
works as it uses to be.

so could you review it again?

Comment 4

[Ginn Chen]

As https://bugzilla.mozilla.org/show_bug.cgi?id=262236#c26
we should not get this one in.

Comment 5

[Ginn Chen]

Attachment: patch revised

Revised patch, its behaviour is just like bug 262236.
I also added a fix for Firefox tree widget, you can verify it with
Firefox->Edit->Preferences->Web Features->Allowded Sites.

Comment 6

[Aaron Leventhal]

Comment on attachment 176701 [details] [diff] [review]
patch revised

I think the up and down arrow key handling should occur in the same places that
they are handled now:
<handler event="keypress" keycode="vk_down" modifiers="accel any">
and
<handler event="keypress" keycode="vk_up" modifiers="accel any">

Comment 7

[[e-mail]]

There are problems with that, because each arrow key is effectively handled
twice. The internal state should be stored in a field, not an attribute. Also
the event.keyCode test for seems wrong.

Comment 8

[Ginn Chen]

Attachment: patch v2

Oops, it's very simple to resolve this problem.
Just fix wrong use of the event.keyCode.

It works well.

Comment 9

[Aaron Leventhal]

Comment on attachment 176847 [details] [diff] [review]
patch v2

Neil, is that right?

Comment 10

[[e-mail]]

Comment on attachment 176847 [details] [diff] [review]
patch v2

Well, it's better than what we had before, although it's not as flexible as the
system that <select multiple> has.

Comment 11

[Ginn Chen]

Checking in xpfe/global/resources/content/bindings/tree.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tree.xml,v  <--  tree.xml
new revision: 1.44; previous revision: 1.43
done
Checking in toolkit/content/widgets/tree.xml;
/cvsroot/mozilla/toolkit/content/widgets/tree.xml,v  <--  tree.xml
new revision: 1.16; previous revision: 1.15
done

Comment 12

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381