257092 - GOK can't grab HTML content and XUL Content

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

GOK can't grab HTML Content (e.g. links in webpage) and some XUL Content (e.g.
right part of Preference dialog). This bug is severe because it blocks any bug
fix for HTML/XUL element interaction with GOK UI-Grab.

Atk object "HTML_CONTAINER" shouldn't have AccessibleText/AccessibleEditableText
interface. Otherwise GOK won't go over the children of "HTML_CONTAINER".

Comment 1

[Louie Zhao]

Attachment: patch v1

In this patch, fix a bug of link. When invoking function of
nsHTMLLinkAccessible[Wrap], mLinkContent must be initialized first.

Comment 2

[Aaron Leventhal]

Comment on attachment 157128 [details] [diff] [review]
patch v1

+	 nsCOMPtr<nsIAccessibleText> accessInterfaceText;
+	 QueryInterface(NS_GET_IID(nsIAccessibleText),
+			getter_AddRefs(accessInterfaceText));

Isn't it simpler to do this?
 nsCOMPtr<nsIAccessibleText> accessInterfaceText = do_QueryInterface(this);

I see that pattern throughout the ATK code. Change it if you want, but that's
not a condition of r=. I am interested to know why it is different from other
parts of Mozilla.

Comment 3

[Henry Jia]

Comment on attachment 157128 [details] [diff] [review]
patch v1

sr = Henry

Comment 4

[Louie Zhao]

Thanks for sr & r. (I can't checkin now because of waiting for my cvs account
update)

This patch follows the pattern throughout the ATK code. We can change
QueryInterface(NS_GET_IID(... to doQueryInterface(... later for all ATK code.

Comment 5

[Louie Zhao]

patch already in trunk. Close this bug.