257177 - xforms-binding-exception thrown incorrectly

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

reading through nsXFormsModelElement.cpp, I came across a bug.

It looks like the code will throw a binding exception if the XPath doesn't
evaluate.  Looking at the spec, it looks like this should be more of a
xforms-compute-exception.

so either need to make the errors more granular or change the exception to be a
compute exception.

Comment 1

[Allan Beaufour]

(In reply to comment #0)
> It looks like the code will throw a binding exception if the XPath doesn't
> evaluate.  Looking at the spec, it looks like this should be more of a
> xforms-compute-exception.
> 
> so either need to make the errors more granular or change the exception to be a
> compute exception.

I agree, both exceptions could occur. But we need to implement the XPath
extensions, so let's ignore it until then :)

Comment 2

[Allan Beaufour]

Attachment: Patch for the above

Here's a patch that should dispatch the corrent events, follwing the 1.1 draft
(http://www.w3.org/TR/xforms11/).

Comment 3

[aaronr]

Comment on attachment 166213 [details] [diff] [review]
Patch for the above

Good code, well placed.

r=aaron

Comment 4

[Darin Fisher]

Comment on attachment 166213 [details] [diff] [review]
Patch for the above

there are other places where we probably need to throw
xforms-binding-exception, but we can take care of those separately.  this looks
good to me.

sr=darin

Comment 5

[Darin Fisher]

fixed-on-trunk

Comment 6

[Allan Beaufour]

Either this bug never actually made it to trunk, or it got lost in the move back
and forth from the branch!

Comment 7

[Allan Beaufour]

Now it is checked in to trunk (again)