Closed
Bug 257375
Opened 20 years ago
Closed 20 years ago
about:mozilla should be localizable through .dtd file
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gorky, Assigned: benjamin)
Details
(Keywords: fixed-aviary1.0, l12y, Whiteboard: [have patch] - need review anyone - affects l10n, and could be pushed out past 1.0 if necessary)
Attachments
(1 file, 1 obsolete file)
4.01 KB,
patch
|
mconnor
:
review+
asa
:
approval-aviary+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040802 Firefox/0.9.1+ (Pitreck)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040802 Firefox/0.9.1+ (Pitreck)
Having translated about:mozilla and about:buildconfig pages requires from us
(localizers) to "hack" toolkit.jar and change mozilla.xhtml and buildconfig.html
in \global. Now, when the whole build process of localized official releases is
covered by mozilla.org, we can't do this modification. Besides, even draft of
trademark policy doesn't allow us to do so. The easiest way to solve the
problem and (by the way) to make L10n teams life easier is to let us translate
contents of those abouts via .dtd or .properties files, just like in
about:plugins case....
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1•20 years ago
|
||
Does firefox use /xpfe/global/resources/content/plugins.html?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•20 years ago
|
||
Ah ignore the comment above, that got in there accidentally. Sorry for the bugspam.
Assignee | ||
Comment 3•20 years ago
|
||
Right now buildconfig is an HTML file, which path is hardcoded in
http://lxr.mozilla.org/aviarybranch/source/netwerk/protocol/about/src/nsAboutRedirector.cpp#73
So I'm happy to create a patch for about:mozilla (it's mostly done in my tree),
but about:buildconfig isn't going to happen (besides, if you're geeky enough to
read about:buildconfig, you're gonna have to know the English word for
"compiler" anyway).
Assignee: bryner → bsmedberg
Summary: about:mozilla and about:buildconfig should be localizable through .dtd file(s) → about:mozilla should be localizable through .dtd file
Assignee | ||
Comment 4•20 years ago
|
||
This has some extraneous changes from bug 257592 in jar.mn, please ignore them.
Assignee | ||
Updated•20 years ago
|
Attachment #157546 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Whiteboard: [have patch] - need review anyone - affects l10n, and could be pushed out past 1.0 if necessary
Comment 5•20 years ago
|
||
Comment on attachment 157546 [details] [diff] [review]
add mozilla.dtd
<bsmedberg> oops, really?
<bsmedberg> that was stupid
Attachment #157546 -
Flags: review?(mconnor) → review-
Assignee | ||
Comment 6•20 years ago
|
||
Let's try this again, same proviso about jar.mn containing bits of bug 257592
Assignee | ||
Updated•20 years ago
|
Attachment #157546 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #157565 -
Flags: review?(mconnor)
Comment 7•20 years ago
|
||
Comment on attachment 157565 [details] [diff] [review]
fix the oops
there we go, although translating an Easter Egg is silly, IMO ;)
Attachment #157565 -
Flags: review?(mconnor)
Attachment #157565 -
Flags: review+
Attachment #157565 -
Flags: approval-aviary?
Assignee | ||
Comment 8•20 years ago
|
||
Fixed on branch, not yet applicable to trunk. (Got a=ben over IRC)
Comment 9•20 years ago
|
||
Comment on attachment 157565 [details] [diff] [review]
fix the oops
a=asa for branch checkin.
Attachment #157565 -
Flags: approval-aviary? → approval-aviary+
Comment 10•20 years ago
|
||
Two more issues
a) The title tag of about:mozilla still uses english text. IMHO there should be
used &mozilla.from; insted.
b) The original reporter asked also for about:buildconfig. Since it's a
different story (see comment #3) I created bug 261911.
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•