258110 - getShellService() doesn't return null on OS X / Default browser box is shown on OS X

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Asaf Romano (gone)]

*** Regression from bug 256029 ***

The try block in getShellSerivce (see URL) doesn't fail on OS X.

js console output:
[xpconnect wrapped nsIShellSerivce]

As a result, the Default Browser box is shown on mac (and of course (1) It
doesn't work (2) the window size is wrong)

Comment 1

[Mike Connor [:mconnor]]

-> pch

we can't ship with this, so fixing now is really critical

Comment 2

[Pierre Chanial]

Attachment: don't load the mac shell service

The Shell Service for Mac is an empty shell, and as said bryner, let's remove
it.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 157962 [details] [diff] [review]
don't load the mac shell service

a=[e-mail]

Comment 4

[Pierre Chanial]

fixed on branch and trunk.
Please, verify it well :)

Comment 5

[Asaf Romano (gone)]

Thanks Pierre, it's ok now. but...:

I'm really not sure that is the fix we want. It's good enough as a workaround
for the upcomming release. but say I want to impl' parts of the shell service on
mac  (e.g. set as wallpaper) or other platforms that do not have a
nsIShellService implementation, must I impl' set default browser (or anything
else that will be shown per getShellService result) as well!?

Comment 6

[Mike Connor [:mconnor]]

if you're going to enable shellservice for Mac at some point, then you do want
to enable set as default browser (otherwise you have to open Safari, iirc). 
That's something that we do need/want.

In any case, this is the right fix until that happens.