258499 - Gmail Invites blocked by new popup blocker

Status: VERIFIED WONTFIX

(SeaMonkey :: UI Design, defect)

Description

[Ryan Polk (Quark)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040908 Firefox/0.10
(Self build)

When clicking the "Invite a friend!" link in Gmail, it warns me of a popup
blocker preventing the window from opening.  Gmail supposedly uses appended
scripts, but I'm specifically clicking on the link it's blocking.

The official aviary from 20040907 correctly shows the new window.  This is
caused by the checkin for bug 252326.

Comment 1

[logan]

I see this with the linux build from 9/8 but not 9/4

Comment 2

[Brendan Eich [:brendan]]

Need this fixed fast.  If jst broke it, I say he has dibs on fixing it. 
Wladimir is welcome to do his fixing for him, since he helped a lot on the patch
that jst landed -- but it's still jst's regression, according to Hoyle.

/be

Comment 3

[Johnny Stenback (:jst)]

I'm on it.

Comment 4

[Johnny Stenback (:jst)]

This was easier than I thought, this doesn't have anything to do with
dynamically loaded scripts etc, it's simply a matter that we block popups from
mousedown events, for whatever reason. Patch coming up, and taking bug...

Comment 5

[Johnny Stenback (:jst)]

Attachment: Allow popups from mousedown events.

Comment 6

[Johnny Stenback (:jst)]

Attachment: Allow popups from mousedown events.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 158240 [details] [diff] [review]
Allow popups from mousedown events.

Quadruple-plus good!  Any other events to consider?

/be

Comment 8

[Johnny Stenback (:jst)]

I *think* we've got the ones we care about now, but others please speak up if
you think of others...

Comment 9

[Johnny Stenback (:jst)]

Fixed on trunk and aviary. Marking FIXED (will land on 1.7 once the new popup
blocker lands there)

Comment 10

[Ryan Polk (Quark)]

Verified with a self build (aviary).  Nice speed ;)

Comment 11

[Johnny Stenback (:jst)]

Thanks, and thanks for filing the bug and verifying that it's fixed, and thanks
to others who helped :-)

Comment 12

[Dorando]

FYI, in bug 239403 it was decided to not allow popups from mousedown events.

Comment 13

[Wladimir Palant]

Hm, the argumentation in this bug seems logical (btw, Gmail appears to have been
produced by Dreamweaver as well, at least partly). And there is another thing:
http://blogs.msdn.com/jeffdav/archive/2004/08/25/220737.aspx. I don't expect
Microsoft to allow popups on mousedown only because of Gmail, so Google will
most probably fix this bug very soon.

Comment 14

[Robert Parenton]

Bug 239403 has a lot of good reasons why we might want to back this out,
especially Bug 239403 comment #12.

Comment 15

[Fareed Rizkalla]

I believe automatic triggering of openning a new window should block, and it
shouldn't block on mouse down event.

Comment 16

[Johnny Stenback (:jst)]

Blocking on mousedown when we don't block on click makes no sense at all IMO.
Relying on the popup blocker to suppress windows from badly coded sites seems
like a mistake to me, especially when it blocks real windows on real sites like
gmail. The popup blocker should suppress windows that sites attempt to spit in a
users' face at seemingly random times, not block windows from opening when the
user interacts with the site. 

Comment 17

[Johnny Stenback (:jst)]

Ok, after more thought, more discussion, and more testing, it does make some
sense to block mousedown from opening popups. And it even matches what IE on
WinXP SP2 does... We're considering backing this out. Stay tuned...

Comment 18

[Johnny Stenback (:jst)]

Reopening as this is now backed out and we've decided to not fix this problem.
Gmail etc will follow with a fix, I'm sure, since it's now broken in both
Firefox and IE on WinXP SP2.

Comment 19

[Johnny Stenback (:jst)]

Marking WONTFIX.

Comment 20

[Jesse Ruderman]

Why can't we be better than IE and allow these requested popups?

Comment 21

[Johnny Stenback (:jst)]

Because we think IE is better than what we'd be if we made this change.
Mousedown on a link doesn't mean you're going to click it, only once you let go
of the mouse button in the same spot we'll treat that as a click, and that's an
activation gesture, whereas just mousedown is not for links. What if you just
want to drag a link? Should sites be able to open popups when you start to drag?
Not IMO.

Comment 22

[Bill Mason]

*** Bug 259110 has been marked as a duplicate of this bug. ***

Comment 23

[Olivier Cahagne]

*** Bug 259146 has been marked as a duplicate of this bug. ***

Comment 24

[Collin Grady]

Ok since my bug was flagged a dupe of this, which it didn't seem like, I'll ask
here.

Why does it continue to block the popups when I have the site flagged as "Allow" ?

Comment 25

[logan]

(In reply to comment #24)
> Why does it continue to block the popups when I have the site flagged as "Allow" ?

works fine for me with gmail.google.com in the whitelist

Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040913 Firefox/0.10

Comment 26

[colours_9]

I have noticed this bug too, but not only in Gmail, but in other web sites that
contains popups.

Comment 27

[Ng Ming Hong]

> I have noticed this bug too, but not only in Gmail, but in other web sites that
contains popups.

This is not a bug, but a feature.
Please read the comments above before commenting...

Comment 28

[alanjstr]

*** Bug 259442 has been marked as a duplicate of this bug. ***

Comment 29

[alanjstr]

I'm confused.  I have gmail.google.com whitelisted.  And yet I can't click
things like Contacts and get menus to open.  All I get is another blocked popup.
 Is the whitelisting being applied to the domain?  Does it matter that its
https?  Going into Options and disabling Popup blocking entirely doesn't seem to
make them work.  

Comment 30

[alanjstr]

Oh yeah, Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913
Firefox/0.10

Comment 31

[Johnny Stenback (:jst)]

(In reply to comment #29)
> I'm confused.  I have gmail.google.com whitelisted.  And yet I can't click
> things like Contacts and get menus to open.  All I get is another blocked popup.
>  Is the whitelisting being applied to the domain?  Does it matter that its
> https?  Going into Options and disabling Popup blocking entirely doesn't seem to
> make them work.  

Could you test with a clean profile? I tried what you're explaining here, and if
I ask Firefox to add gmail to the whitelist when I get a message about a blocked
popup, I can from there on always open all windows that gmail wants to open.

Comment 32

[alanjstr]

> Could you test with a clean profile?
Ok, it appears to have something to do with TBE 1.10.2004071201.  I'll try a
newer version.

Comment 33

[alanjstr]

Well, its still a problem in the latest TBE.  I have no idea why it would get
caught as a blocked popup even when popups are enabled, but obviously its a TBE
problem.

Comment 34

[daniel doorduin]

I've also a problem with the links "invite  a friend!" and "Contacts" in gmail.
However, I recieve no warning that a popup is blocked. Nothing happens
instead... Also filed as Bug 259769 (at that time I hadn't found this bug in my
search, sorry...)

Comment 35

[PikeUK]

*** Bug 259694 has been marked as a duplicate of this bug. ***

Comment 36

[Grant Hill]

I attached a comment to bug # 259694 as I was experiencing the same problem
with: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040916 Firefox/0.10

Resolved by removing the tabbrowser extension, just thought I should post this
to remind people to check for extensions breaking things.

Comment 37

[charles anathema]

I also have what I think is the latest TBE and firefox 1.0PR on Windows XP Pro.

Either way, even if i totally shut the popup blocker off, it still blocks
popups. If I add gmail to the whitelist, it still blocks it. I added mousedown
to the list of allowed actions, still no go.

Is this all a TBE problem ?

Comment 38

[Johnny Stenback (:jst)]

Charles, do all those problems go away if you try a clean install w/o any
extensions what so ever? If so, can you then install TBE and see if all those
problems re-appear?

Comment 39

[Ng Ming Hong]

(In reply to comment #37)
> Is this all a TBE problem ?
You can check it out yourself by:
- Disabling TBE;
- Uninstalling TBE; or
- Remove the whole profile

No matter what. It is 100% not a firefox bug because it works for many people
who are using pure and clean Firefox 1.0PR. Just add gmail to the whitelist.

Comment 40

[alanjstr]

Adding gmail to the whitelist does not work.  Nor does disabling the popup
blocker.  But it is obviously caused by TBE for me.

Comment 41

[Johnny Stenback (:jst)]

Did anyone contact the TBE owner/maintainer about this issue?

Comment 42

[charles anathema]

I have verified for myself that yes this is most definatly a TBE bug, im going
to email the tbe guys on this see what they say.

With TBE installed i cannot even click the 'images' or 'groups' button on
google.com.

Comment 43

[Johnny Stenback (:jst)]

For the record, gmail is now fixed and no longer opens windows in a way that is
blocked by the popup blocker in Firefox and/or IE.