258667 - leak when opening a tab group that's on the personal toolbar

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I leak when I open a tab group that's on the personal toolbar in Firefox.  Patch
to be attached.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

I've fixed too many leaks in this code not to do this (convert to nsCOMPtr /
nsCOMArray).

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 158678 [details] [diff] [review]
patch

Yeah, I'm all for doing this, thanks dbaron! r+sr=jst

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2004-09-12 20:22 -0700.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 158678 [details] [diff] [review]
patch

Making approval requests for after Firefox 1.0PR.

Comment 6

[Frederic Bezies]

Seems to kill compilation under VC++ .Net 2003 (using free toolkit) with this
error :

"c:\logs\moz\mozilla\dist\include\layout\nsPresCOMPtr.h(200) : error C2873:
'AddRef' : symbol cannot be used in a using-declaration

c:\logs\moz\mozilla\dist\include\layout\nsPresCOMPtr.h(200) : error C2027:  use
of undefined type 'imgIRequest'
../../dist\include\layout\nsPresContext.h(64) : see declaration of 'imgIRequest'

c:\logs\moz\mozilla\dist\include\xpcom\nsCOMPtr.h(201) : error C2873: 'Release'
: symbol cannot be used in a using-declaration

make[5]: ** [nsNativeTheme.obj] Error 2

And then build process is killed :[

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Unrelated to this bug, and there's no file called nsPresCOMPtr.h.

Comment 8

[Frederic Bezies]

Well, so my computer is guilty there. Strange point is that I can build without
problem firefox or thunderbird (branch based code).

Sorry for spamming the bug.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 158678 [details] [diff] [review]
patch

a=asa for checkin to the branches.

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_7_BRANCH, 2004-09-14 13:38 -0700.
Fix checked in to AVIARY_1_0_20040515_BRANCH, 2004-09-14 13:39 -0700.