258737 - Upgraded Extension does not overlay UI

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Steps to reproduce:

1) set app.extensions.version to "0.9"
2) install Magpie 3.11 from http://www.bengoodger.com/software/tabloader/
3) restart, note "Magpie Tools" submenu under Tools menu
4) reset app.extensions.version
5) set "extensions.lastAppVersion" to "0.9"
6) close Firefox
7) set <profile>/compatibility.ini's "build id" field to something different
8) start Firefox
9) dismiss the update checker (Don't Check)
10) install Magpie 3.1.2 from http://www.bengoodger.com/software/tabloader/
11) restart firefox
12) no menu items!

Magpie was disabled by the checkformismatches process and when it was upgraded
the EM disabling flags were cleared, but EM never told the chrome registry on
upgrade that it should allow overlays again.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Prevents upgrades from working properly - pretty bad. Fixed.