258788 - Reflect GNOME Default shortcuts in the UI

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Pierre Chanial]

The following patch does the following for GNOME:
- shift-ctrl-Z for redo
- ctrl-A for select all
- ctrl-Y for the download manager

in addition for the mac, it shows shift-accel-Z for redo (that's one that we
actually implement) instead of accel-Y, as specified in the apple HIG.
(http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_7_section_4.html#//apple_ref/doc/uid/TP30000356/TPXREF127,
in the undo section)

For the Ctrl-K part, I just moved its duplicated definition out of the #ifdef
since it's now a xp shortcut and commented to make clear that ctrl-J is still
needed in case the user has chosen the emacs bindings.

Comment 1

[Pierre Chanial]

Attachment: patch

Comment 2

[Pierre Chanial]

Comment on attachment 158478 [details] [diff] [review]
patch

requesting r=bryner, a=ben

Comment 3

[chris hofmann]

msg from pch to aviary:

Since bryner's native keybinding patch has landed I think that the GNOME default
edit keybindings should be reflected in the UI (ctrl-A, shift-ctrl-Z). I've
written a patch in bug 258788. and I am requesting a quick r=bryner and a=ben if
it's not too late. I won't be able to check it in before sth like 11-12pm EST,
so feel free to drive it if it is approved.

pch

Comment 4

[chris hofmann]

bryner not sure about the patch, so we should just consider this for final at
this point.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 158478 [details] [diff] [review]
patch

a=asa (on behalf of the aviary team) for checkin to the aviary branch.

Comment 6

[Steffen Wilberg]

pch checked this into aviary on 2004-09-16 12:05.

Comment 7

[Jaap A. Haitsma]

Shouldn't this bug be closed? The patch has been applied and it works for me in
the 1.0 RC

Comment 8

[Steffen Wilberg]

Fixed on trunk by the aviary landing.