261544 - Menu items "Delete host" and "Delete domain" aren't visible when history tree is empty

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cs-CZ; rv:1.8a3) Gecko/20040817
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; cs-CZ; rv:1.8a3) Gecko/20040817

1) I run Mozilla 1.8a3 with Profile manager.
2) I create new profile and run Mozilla with this profile.
3) I go to mainmenu "Go -> History" (Ctrl+H).
4) This item opens new dialog (History).
5) I choose Edit in mainmenu. There is a problem becouse items "Delete host" and
"Delete domain" aren't visible. This items are empty. 

When i click on "Delete host", this item is visible now.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Stefan Borggraefe]

Confirming with a Linux build from today. You can also clear the history and
open the History Window to see this bug.

Comment 2

[Adam Hauner]

Confirming based on Stefan's repro.

Comment 3

[Pavel Cvrcek [:JasnaPaka]]

I think that add these lines to file history.js fix this problem

file: comm.jar!\content\communicator\history
function: function HistoryCommonInit()

add lines:
gDeleteByHostname.label = gHistoryBundle.getString("deleteHostNoSelection");    
gDeleteByDomain.label = gHistoryBundle.getString("deleteDomainNoSelection");

What do you think?

Comment 4

[Stefan Borggraefe]

Attachment: Patch

updateHistoryCommands(); takes care for the menu items.

I also fixed the exception that is caused by
HistoryTree.view.selection.select(0); when the tree is empty.

Comment 5

[[e-mail]]

Comment on attachment 179111 [details] [diff] [review]
Patch

In the history manager gHistoryTree.view.selection.select(0) (usually) already
calls updateHistoryCommands via the select event, so I'd appreciate it if you
didn't call it twice in this case. Of course you still need to select the first
row in the sidebar.

Comment 6

[Stefan Borggraefe]

Attachment: Patch V1.1

Like this?

Comment 7

[[e-mail]]

Comment on attachment 179126 [details] [diff] [review]
Patch V1.1

Yeah, that works. r+sr=me

Comment 8

[Stefan Borggraefe]

Fix checked in.