261796 - Two .cvsignore files in toolkit/ mention files which are actually in CVS

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Gervase Markham [:gerv]]

The following list of files are included in the .cvsignore file for their
directory, but are actually kept under source control, and pulled and built as
part of the build process.

mozilla/toolkit/xre: nsNativeAppSupportBase.cpp
mozilla/toolkit/xre: nsNativeAppSupportWin.cpp 

This means that:

- It's not possible to change these files without fixing .cvsignore because CVS
won't check them in

- Any attempt to cvs import a checked-out copy of Mozilla into another CVS tree
excludes these files and therefore Mozilla won't build when checked out of the
new tree. 

This is due to cvs import -I ! still respecting .cvsignore - see the notes about
the -I option here:
https://www.cvshome.org/docs/manual/cvs-1.11.17/cvs_18.html#SEC178

If these files should not actually be listed in .cvsignore, they should be
removed from it.

Gerv

Comment 1

[Daniel Veditz [:dveditz]]

This is fixed on the trunk, are you saying we need it on the aviary branch?

Comment 2

[Gervase Markham [:gerv]]

Actually, that's where I discovered it, although I filed bugs to make sure it
was OK on the trunk. I suppose that whether it gets fixed on the aviary branch
is up to whoever's in control of that area of the code on that branch :-)

Gerv

Comment 3

[Benjamin Smedberg]

Aviary branch is pining for the fjords; long live the trunk.