262300 - "Composition & Addressing" and "Advanced Account Settings" should be handled by Identity Manager

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Volkmar W. Pogatzki]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040929 Firefox/0.10
Build Identifier: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2004-09-30-06-0.8/thunderbird-i686-linux-gtk2+xft.tar.gz

Creating an account with multiple identities does not provide a per-identity
interface for settings as "Composition & Addressing" or "Advanced Account
Settings" but only once per account. 

For any but the first identity, important settings like the following can only
be adjusted manually:

  user_pref("mail.identity.id2.doBcc", false);
  user_pref("mail.identity.id2.doBccList", "");
  user_pref("mail.identity.id2.smtpServer", "smtp1");
  user_pref("mail.identity.id2.compose_html", false);
  user_pref("mail.identity.id2.reply_on_top", 0);
  user_pref("mail.identity.id2.sig_date", 0);
  user_pref("mail.identity.id2.sig_bottom", true);

These settings should be handled by the identity manager. The problem affects
movemail accounts as well as pop accounts.

Reproducible: Always
Steps to Reproduce:
1. Create a new profile with one account selecting "Global Inbox".
2. Let Thunderbird start and go to Tools, AccountSettings, AccountSettings.
3. Use "Manage Identities..." to create a second or more identities.


Actual Results:  
There is no way to adjust the outgoing server per identity nor anything for
"Composition & Addressing" per id.

Expected Results:  
There should be a full set of options for all "user_pref("mail.identity.id2..."
settings per each identity.

Comment 1

[Volkmar W. Pogatzki]

Attachment: Composition & Addressing

Comment 2

[Volkmar W. Pogatzki]

Attachment: Outgoing Server per each Identity, please

Comment 3

[Stefan Borggraefe]

(In reply to comment #0)
> There is no way to adjust the outgoing server per identity

The patch in bug 202468 (which currently seems stuck somehow :-( ) fixes this.

Comment 4

[Scott MacGregor]

not a stop ship bug

Comment 5

[Mike Cowperthwaite]

The Account Settings | Copies & Folders settings also need to be included in the 
full identity UI -- including, specifically, these preferences:

mail.identity.id2.fcc
mail.identity.id2.fcc_folder
mail.identity.id2.draft_folder
mail.identity.id2.stationery_folder

Comment 6

[Mike Cowperthwaite]

*** Bug 266656 has been marked as a duplicate of this bug. ***

Comment 7

[Attila Bognar]

The UI for identities should be able to help setting:

mail.identity.id2.request_return_receipt_on

Comment 8

[Scott MacGregor]

i have a fix to finish implemnting the multiple identities UI

Comment 9

[Scott MacGregor]

Attachment: screen shot with tabbed panels for composition & copy folders

Comment 10

[Scott MacGregor]

Attachment: finish implementing multiple identity UI

Comment 11

[Scott MacGregor]

Comment on attachment 165378 [details] [diff] [review]
finish implementing multiple identity UI

David, it's not as big as it looks. You can ignore the two new files
(am-copiesOverlay.xul and am-addressingOverlay.xul). These two files just break
out two xul fragments from am-copies.xul and am-addressing.xul so I can re-use
them in the multiple identity UI without duplicating the XUL.

The patch adds several tabs to the Edit/Add new multiple identity dialog for
Copies & Folders and Addressing & Composition.

I had to re-name some methods in am-copies.js and am-addressing.js (onSave and
onInit) in order to avoid some naming collisions since both of these JS files
are now loaded by the multiple identities UI.

Comment 12

[Scott MacGregor]

fixed branch and trunk

Comment 13

[Mike Cowperthwaite]

The UI is indeed in place; I see it in version 0.9+ (20041112).
Very nice, Scott -- thanks!

This UI does not allow per-identity specification of the SMTP server; for this 
feature, see bug 202468.


(In reply to comment #7)
> The UI for identities should be able to help setting:
> 
> mail.identity.id2.request_return_receipt_on

The setting 'request_return_receipt_on' is not identity-specific.  You'll need 
to open a new request for that.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Checked with version 0.9+ (20041112)

After the current implementation of the identity manager some behaviours aren't
correct:

1. Copies & Folders

When adding a new identity to any account the prefs within this tabs aren't set
to the current account. Instead the default account is selected. This should be
changed to use the default values from the current account. Additionally no
radio button is selected. We should activate e.g. '"Sent" Folder on'. The
mentioned prefs apply to all entries on this tab.

2. Composition & Adressing

Dropdown boxes for automatically quote aren't initialized corrently. Select and
deselect the checkbox to see the UI bug. After deselecting the checkbox both
dropdown boxes are grayed out. The second one won't become activated again. When
using "select the quote" the second box should be activated. Under addressing
the global LDAP settings aren't selected.

Additionally I miss a pref. Scott, you have forgotten to include the
availability to set the pref: mail.identity.idxxx.smtpServer

=> Reopen

Comment 15

[Scott MacGregor]

file new bugs for any other issues.

We won't be letting you set SMTP servers here. That's what Global inbox is for. 

Comment 16

[Mike Cowperthwaite]

(In reply to comment #15)
> We won't be letting you set SMTP servers here.
> That's what Global inbox is for. 

See bug 202468.

Verifying this UI has been implemented, both in TB and in Moz MailNews.

Comment 17

[Mike Cowperthwaite]

*** Bug 234698 has been marked as a duplicate of this bug. ***