262866 - Invalid path offered when file already exists (Save all attachments)

Status: VERIFIED FIXED

(MailNews Core :: Attachments, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10.1
Build Identifier: Thunderbird version 0.8 (20040913)

I guess it is a mail/news bug, but as I use only Thunderbird, I submited it
here. I didn't find any doubled in MailNews bugs.

Reproducible: Always
Steps to Reproduce:
1. find message with attachments
2. save at least one attachment to dir
3. save all attacments to that dir
4. click cancel in dialogue (not to replace file)
Actual Results:  
Save file dialogue appeared with whole path in file name field begining with c-\
instead of c:\

Expected Results:  
There should be no path in file name field, or at least it should begin with c:\

This is probably MailNews issue, but I am using Thunderbird so I am reporting
here (I didn't find any duplicates in MailNews)

Comment 1

[Mike Cowperthwaite]

*** Bug 270384 has been marked as a duplicate of this bug. ***

Comment 2

[Mike Cowperthwaite]

Reproduced with TB 0.9+1112, and with Moz 1.8a5-1019.

Behavior occurs with MailNews, so updating Product.
Duplicate is from Mac OS X, so updating platform.

Comment 3

[Mike Cowperthwaite]

*** Bug 273183 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Cowperthwaite]

*** Bug 287343 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Cowperthwaite]

*** Bug 291978 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Cowperthwaite]

*** Bug 222752 has been marked as a duplicate of this bug. ***

Comment 7

[Katsuhiro MIHARA]

Attachment: proposed patch

get leaf name before open filepicker.

Comment 8

[Katsuhiro MIHARA]

Attachment: proposed patch (removed all tabs)

Comment 9

[Katsuhiro MIHARA]

Comment on attachment 182469 [details] [diff] [review]
proposed patch (removed all tabs)

I want a reviewer to review this patch. But I don't know who are reviewers of
mailnews.

Comment 10

[Mike Cowperthwaite]

*** Bug 315275 has been marked as a duplicate of this bug. ***

Comment 11

[Mike Cowperthwaite]

*** Bug 229233 has been marked as a duplicate of this bug. ***

Comment 12

[Magnus Melin [:mkmelin]]

*** Bug 322924 has been marked as a duplicate of this bug. ***

Comment 13

[Magnus Melin [:mkmelin]]

*** Bug 336567 has been marked as a duplicate of this bug. ***

Comment 14

[Magnus Melin [:mkmelin]]

*** Bug 348380 has been marked as a duplicate of this bug. ***

Comment 15

[Magnus Melin [:mkmelin]]

Attachment: proposed fix based on the patch by Katsuhiro MIHARA

This is a slightly modified patch based on the earlier one by Katsuhiro MIHARA. (I don't know what the braces were supposed to do there... ?)

Comment 16

[David :Bienvenu]

Comment on attachment 246627 [details] [diff] [review]
proposed fix based on the patch by Katsuhiro MIHARA

this fixes the problem; thx for the patch. My one worry is the error returns, which will prevent the UI from coming up (note that we handle the other errors w/o returning). But I don't think we should encounter these errors...

Comment 17

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/base/src/nsMessenger.cpp 	1.349

Comment 18

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/base/src/nsMessenger.cpp 	1.320.2.16

Comment 19

[Carsten Book [:Tomcat]]

Verified fixed for branch/1.8.1.2 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070124 Thunderbird/2.0b2pre Mnenhy/0.7.4.10002 ID:2007012504