Closed Bug 262917 Opened 20 years ago Closed 19 years ago

r:\mozilla\layout\html\document\src\nsframeframe.cpp(632) : warning C4715: 'ConvertOverflow' : not all control paths return a value

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.8beta3

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(2 obsolete files)

r:\mozilla\layout\html\document\src\nsframeframe.cpp(632) : warning C4715:
'ConvertOverflow' : not all control paths return a value

perhaps a default case w/ ns_error?
Attached patch proposal (obsolete) — Splinter Review
Assignee: dbaron → timeless
Status: UNCONFIRMED → ASSIGNED
Attachment #187544 - Flags: superreview?(dbaron)
Attachment #187544 - Flags: review?(dbaron)
How about putting it outside the switch?
Attached patch is this what you mean? (obsolete) — Splinter Review
Attachment #187602 - Flags: superreview?(dbaron)
Attachment #187602 - Flags: review?(dbaron)
Attachment #187544 - Flags: superreview?(dbaron)
Attachment #187544 - Flags: superreview-
Attachment #187544 - Flags: review?(dbaron)
Attachment #187544 - Flags: review-
Attachment #187602 - Flags: superreview?(dbaron)
Attachment #187602 - Flags: superreview+
Attachment #187602 - Flags: review?(dbaron)
Attachment #187602 - Flags: review+
Attachment #187602 - Flags: approval1.8b3?
Comment on attachment 187602 [details] [diff] [review]
is this what you mean?

a=bsmedberg for checkin on 6/30 only
Attachment #187602 - Flags: approval1.8b3? → approval1.8b3+
Attachment #187544 - Attachment is obsolete: true
Comment on attachment 187602 [details] [diff] [review]
is this what you mean?

mozilla/layout/generic/nsFrameFrame.cpp 	3.285
Attachment #187602 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta3
Product: Core → Core Graveyard
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: