26413 - Added News Account Picks up Identity Prefs from Deleted Mail Account

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect, P1)

Description

[sol]

If you delete a Mail account, then add a News account, the identity preferences 
specified in the Account Wizard for the News account are ignored. Instead, the 
identity preferences for the deleted Mail account are inserted in the newly 
created News account.

Build ID: 2000-02-01-08

Steps to reproduce:
1. Launch Mail
2. Delete one of your email accounts (Edit | Account Settings; select top level 
of email account, and press "Delete" button)
3. Add a news account using the Account wizard (Edit | Account Settings; hit "Ne 
Account" button, proceed through wizard to create a "news" account). At the end 
of the wizard, you are left in the Account Settings screen.

Actual result: No identity prefs for the news account are displayed.
Expected result: The identity prefs you just entered in the Wizard for the news 
account are displayed.

4. Press "OK" to exit from the "Account Settings" dialog.
5. Open Account Settings again (Edit | Account Settings) and select the newly 
created news account

Actual result: Identity prefs for newly created news account contain the 
identity settings for the email account you recently deleted
Expected result: Identity prefs you just entered in the Wizard for the news 
account should be displayed.

Note: The newly created identity *is* available in the "From" field of the Mail 
Compose window.

Comment 1

[Alec Flett]

gack, that's bad

Comment 2

[lchiang]

should I nominate for beta1 since this could be confusing to the user?

Comment 3

[sol]

Before nominating for Beta1, I'd like to see if the same behavior occurs when 
deleting a mail account then adding another mail account. I think this usage 
pattern will be common enough to warrant nominating for beta1.

Unfortunately, yesterday's build was so horked that I can't test this right now. 
If someone else can, that would really help.

Comment 4

[Alec Flett]

yeah, I know exactly why this is happening, and it should occur with both mail

and news accounts, in any combination....

Comment 5

[sol]

If that's the case, I'm nominating for Beta1. A large percentage of users who 
try out our multiple account feature will hit this bug, and the bug results in 
data loss. High frequency, bad result.

Comment 6

[leger]

Putting on PDT+ radar for beta1.

Comment 7

[Alec Flett]

ok, I've got a fix in my tree.

Comment 8

[Alec Flett]

fix checked in

Comment 9

[Ninoschka Baca]

Build 2000-02-15-09M14: NT4
Haven't tried todays build on Linux or Mac yet.
Reopening.

- Different result: After adding the News server and selecting the Identity 
panel, it displays a panel like the "Local Folders" panel where it states that 
this account is special and does not have an identity. (related to bug# 27913).
- After closing Account Settings and reopening then I noticed:
  - The News Identity panel now looks correct as far as the fields displayed.
  - The Account Name is wrong: It points to the deleted account
  - The Email Address is correct: It points to the News account's email.

Comment 10

[Ninoschka Baca]

Build 2000-02-15-09M14: Mac 8.5.1
Same results as the 2/15 NT build.

Comment 11

[Alec Flett]

hrrm... that's really odd.
looking into it.

Comment 12

[Alec Flett]

ok, I just fixed #27913... now to figure out why these deleted account ghosts 
are still haunting the account manager. It's like the end of a horror movie 
where the villain just won't die.

Comment 13

[Alec Flett]

ahah! I figured out what's going on. I wasn't clearing currentServerId and
currentPageId, which meant that when an account got deleted and another account
was selected, sometimes the cached data from the old serverId/PageID would get
dumped to the most recently clicked account, which was bad..

fix in hand, reviewed, approved, and waiting for verifications to be done so I
can check in.

Comment 14

[Alec Flett]

done

Comment 15

[Ninoschka Baca]

Bug# 28982 needs to be fixed so that I can verify this bug. Selecting various 
panels is making the app crash.

Comment 16

[Ninoschka Baca]

Build 2000-02-29-08M15: NT4, Linux 6.0, Mac 8.5.1
Verified Fixed.