265607 - logic error in GtkPromptService::Prompt

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 Galeon/1.3.17.99
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 Galeon/1.3.17.99

GtkPromptService::Prompt
[http://lxr.mozilla.org/seamonkey/source/embedding/browser/gtk/src/GtkPromptService.cpp#184]
:
184     if (aConfirm) {
185         if (*aValue)
186             nsMemory::Free(*aValue);
187         prompter.GetTextValue(aValue);
188     }

It checks aConfirm, but should check *aConfirm for whether to get the value from
the prompter, like ::PromptUsernameAndPassword and ::PromptPassword do. Patch
coming up.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: fix

Comment 2

[Christopher Blizzard (:blizzard)]

-> marco

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 163007 [details] [diff] [review]
fix

A simple, gtk embedding-only fix, no risk.

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: rediff'd patch against trunk, no code changes

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

trunk:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.9; previous revision: 1.8
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.8.2.1; previous revision: 1.8
done