266259 - memory leak in nsCharsetConverterManager::GetCharsetLangGroupRaw()

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Boying Lu]

Following codes fragement will cause memory leak:
In nsCharsetConvertManager::GetCharsetLangGroupRaw()
{
 ...
 res = GetBundleValue(mDataBundle, aCharset, NS_LITERAL_STRING(".LangGroup"),
langGroup);
 
 *aResult = NS_NewAtom(langGroup);

 return res;
}

If the call GetBundleValue() fails. NS_NewAtom(langGroup) will be called.

But in the following codes (in SetCharsetLangGroup()):

res = gCharSetManager->GetCharsetLangGroupRaw(aCharSetInfo->mCharSet,
                                                &aCharSetInfo->mLangGroup);
if (NS_FAILED(res)) {
  aCharSetInfo->mLangGroup = NS_NewAtom("");

if NS_FAILED(res) is true, NS_NewAtom("") will be called, which will cause the
reference count of (class AtomImpl*)(aCharSetInfo->mLangGroup) to increse twice.
This is incorrect.

Comment 1

[Boying Lu]

Attachment: patch v0

Comment 2

[Boying Lu]

Comment on attachment 163553 [details] [diff] [review]
patch v0

Can you give r/sr? Thanks

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 163553 [details] [diff] [review]
patch v0

r=smontagu

Comment 4

[Johnny Stenback (:jst)]

*** Bug 266386 has been marked as a duplicate of this bug. ***

Comment 5

[Boying Lu]

Attachment: same patch but based on latest code base

Comment 6

[Jungshik Shin]

Comment on attachment 182237 [details] [diff] [review]
same patch but based on latest code base

transfering r/sr and asking for a to all branches. This is a very low risk
patch that gets rid of a memory leak.

Comment 7

[Robin Lu]

checked in trunk

Comment 8

[Jungshik Shin]

urh... the tree is frozen so that you're not supposed to check in without approval.

Comment 9

[chris hofmann]

Comment on attachment 182237 [details] [diff] [review]
same patch but based on latest code base

a=chofmann for trunk only. this will get the fix in 1.1a and 1.8b2.   we are
only taking critical security fixes on the branches