266905 - Mozilla crash or hang on POP3 mail download, if "Run Filter on Folder" is executed [@ nsMsgFilter::LogRuleHit]

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[WADA:World Anti-bad-Duping Agency]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041029
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041029

Mozilla crash or hang on POP3 mail download,
if "Run Filter on Folder" is executed on Inbox manualy before download.
Because POP3 users usually enable automatic download, Mozilla hangs or crashes
suddenly.
When this hang, Web access by Broweser also hangs.

Reproducible: Always
Steps to Reproduce:
0.Preparation
 0-1.Create new profile and start Mozilla Mail&News
 0-2.Define a POP3 account
     - Do not use Global Inbox for ease of test
     - Do not use "Leave message on server" -> Download all
 0-3.Create a folder named "TEST"
 0-4.Compose a mail, and send it to myself, and receive it to inbox.  
     From: = myself, To: = myself
     Subject: test-1 
     (body can be any text)
     => a mail is received to Inbox
1.Create a filter for this account
  If "sender" is me and "To" is me and "Subject" begins with 'test',
  Then move to folder "TEST".
  (Filter Log is enabled)
2.Single "Run Filter" -> Hang
  2-1.Execute "Run Filter on Folder" on Inbox
      => A mail("test-1") in Inbox is moved to "TEST" folder.
  2-2.Compose a new mail
      - "Edit As New" on mail of subject="test-1"
      - Change subject to "test-2"
      - Send "test-2" to myself
  2-3."Get New Messages" on this account
      ==> Mozilla Mail&News hang
          - Mail of "test-2" is received in Inbox(or moved to "TEST" by filter)
          - Try to read the mail -> nothing is displayed
      ==> If Broweser is active, Browser access to Web is also hangs.
3.Kill Mozilla
  3-1.Close all Mozilla windows
      ==> Windows are closed but Mozilla process still active
  3-2.Kill Mozilla process from Task Manager(Win-2K,Win-XP)
4.Restart of Mozilla Mail&News
  ==> 2 mails of subject="test-2" appears in "TEST"
      - 1 on hang (recieved but deleted from server yet)
      - 1 by automatic dowload on restart
5.Multiple "Run Filter" -> Hang
  5-1.Move all mails from "TEST" to "inbox"
  5-2.Execute "Run Filter on Folder" on Inbox (1)
  5-3.Move all mails from "TEST" to "inbox"
  5-4.Execute "Run Filter on Folder" on Inbox (2)
  5-5.Repeat 5-3 & 5-4 several times if required
      => Mails are moved to "TEST" folder.
  5-7.Compose a new mail
      - "Edit As New" on mail of subject="test-1"
      - Change subject to "test-N"
      - Send "test-N" to myself
  5-8."Get New Messages" on this account
      ==> Mozilla crashes
          Talkback was sometimes took, but not produced when today's test.
Actual Results:  
Mozilla hang or crash

Expected Results:  
No hang or crash

Workaround:
 Do not use manual "Run Filter on Folder"

Comment 1

[WADA:World Anti-bad-Duping Agency]

Talkback IDs I sent due to sudden crash (probably caused by this bug).
As far as I remember, I always executed "Run Filter on Folder" when crash
occured on next automatic mail download.

(1) Crash on 2004081908-trunk/Win-2K
    TB621852K

(2) Crash on 2004092306-trunk/Win-2K
    TB982039E
    TB979583H

(3) Crash on 2004100906-trunk/Win-2K
    TB1270738W
    TB1263823Q
    TB1256690X
    TB1219910Q

Comment 2

[Hermann Schwab]

Talkbacks not mentioned aren´t in the database
 
> (3) Crash on 2004100906-trunk/Win-2K
>     TB1270738W 	 nsMsgFilter::LogRuleHit 31991fb7
>     TB1263823Q         nsCOMPtr_base::assign_with_AddRef 64b05a42
>     TB1256690X         nsMsgFilter::LogRuleHit 31991fb7
>     TB1219910Q         No entry for Incident ID: 1219910
 

9 crashes found where the Stack Signature contains 'nsmsgfilter::logrulehit' 
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=+nsMsgFilter%3A%3ALogRuleHit&vendor=All&product=All&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid

maybe on linux too:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=1301533

Comment 3

[WADA:World Anti-bad-Duping Agency]

Change Assigned-to to David, since I've learnd next rule :-) ;
 - the first rule of Bugzilla politics: give the bug to the right developer
(I heard that Seth Spitzer has changed his job and is very rarely active in
Mozilla development lately. David, could you help me?)

Is is this filter problem? Or download problem?
How can I get data for problem analysis when hang or after "Run filter on folder"?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming.  I just saw this with Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8b2) Gecko/20050609

Comment 5

[timeless]

Attachment: look before leaping but don't complain

Comment 6

[David :Bienvenu]

Comment on attachment 185836 [details] [diff] [review]
look before leaping but don't complain

this could be null if NotifyServerUnloaded is called - other than that, I don't
know how it could be null.

Comment 7

[timeless]

Comment on attachment 185836 [details] [diff] [review]
look before leaping but don't complain

mozilla/mailnews/base/search/src/nsMsgFilter.cpp	1.101

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Timeless: patch landed, so mark this FIXED?

Comment 9

[WADA:World Anti-bad-Duping Agency]

Mozilla Suite nightly/latest-trunk(2005061306 ZIP build/Win-32) still crashes
when "Edit Message Filter" after "Run Filters on Folder".
(1) Start Mozilla Browser and Mozilla Mail&News using my current profile.
    => POP3 servers access on start-up but no mail is downloded
       because no new mail.
(2) Tools/"Run Filters on Folder" on "Inbox" folder.
    => No mail is moved because no matching mail.
(3) Tools/"Message Filters"
    (3-1) "Edit" an enabled filter, then save("OK") with no modification
          => No problem
    (3-2) "Edit" another enabled filter
          => Crash. Talkback was not kicked.
I tried above steps three times and Mozilla crashed in any attempt of step (3-2).

Followings are all checkins on mozilla/mailnews/base/search/src/nsMsgFilter.cpp
since 2005/01/01.
> 2005-06-10 15:15 1.101 Bug 266905 Mozilla crash or hang on POP3 mail download,
>                        if "Run Filter on Folder" is executed
> 2005-06-01 11:13 1.100 support for filters that reply/forward messages
> 2005-04-20 07:45 1.99  Bug 262184: support Copy as a filter action
                         (as in tbird 1.0). Finally landing on the trunk

Comment 10

[WADA:World Anti-bad-Duping Agency]

Above comment #9 was for Bug 242600.
Sorry for mis-operation and spam.

Comment 11

[WADA:World Anti-bad-Duping Agency]

timeless, FIXED by what?
(a) By your patch of attachment 185836 [details] [diff] [review] marked obsolete by yourself, which is
already checked-in.
(b) By patch for Bug 242600?

Comment 12

[timeless]

probably the other one, but i only care if this is really not fixed.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

According to http://talkback-public.mozilla.org,
MozillaOrgMozillaTrunkWin322005060906 was the last build to crash, so this bug
is Verified FIXED.