266930 - ua.css should now be installed (symlinked) rather than copied

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[[e-mail]]

On 2000/07/31 cls checked in a patch to copy ua.css in case MathML changed it;
bz claims that this is no longer necessary.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Neil, I don't really know build system stuff well enough to review it..

Comment 3

[rbs]

Comment on attachment 164017 [details] [diff] [review]
Proposed patch

I am not sure of the benefit either.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The benefit is not having to remember to build in some random directory for
ua.css (when other similar files don't require any rebuild).

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 164017 [details] [diff] [review]
Proposed patch

As long as this properly overwrites the copied file with the symlink when doing
a depend build that picked up the change, sr=dbaron.

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FWIW, it looks like SVG modifies the ua.css in dist, which leads to
modifications of what's in the tree, so we really weren't quite ready for this.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Sounds like we should put the SVG import inside a preprocessor directive and
preprocess ua.css, then....

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I backed this out because of the SVG thing -- we don't want people accidentally
checking that in because their srcdir was tainted.

But this would still be good to do once SVG is fixed.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I think we really want to make SVG work like MathML, no?)

Comment 11

[Boris Zbarsky [:bzbarsky]]

Yes; that's why we have the catalog sheets stuff...

Comment 12

[tor]

SVG has been fixed so that it no longer munges ua.css.

Comment 13

[[e-mail]]

Attachment: Updated for bitrot

Comment 14

[[e-mail]]

Fix checked back in :-)