Closed
Bug 269661
Opened 21 years ago
Closed 21 years ago
libpref should not depend on CAPS
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
|
11.17 KB,
patch
|
caillon
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
this is another path via which standalone necko depends on caps and thus layout
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #165808 -
Flags: review?(caillon)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta
|
||
Comment 2•21 years ago
|
||
Comment on attachment 165808 [details] [diff] [review]
patch
Sure, but how about calling it nsIPrefSecurityManager or something?
nsISecurityPrefCheck seems a bit weird because the interface isn't necessarily
as extensible in the future and to me sounds like something that would be an
instance as opposed to a service.
Attachment #165808 -
Flags: review?(caillon) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 165808 [details] [diff] [review]
patch
thanks, that sounds good - I couldn't think of a good name
Attachment #165808 -
Flags: superreview?(dveditz)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 165808 [details] [diff] [review]
patch
sr=dveditz
Attachment #165808 -
Flags: superreview?(dveditz) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
oops. this was checked in 2005-02-06 04:39.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•