271700 - Crash when I try to pass '@mozilla.org/messenger/progress;1' object to resgisterListener() method of the same object.

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616

I create object '@mozilla.org/messenger/progress;1', query nsIMsgProgress
interface, query nsIWebProgressListener interface. I try to pass
nsIWebProgressListener to registerListener() method of nsIMsgProgress.

Reproducible: Always
Steps to Reproduce:
1. var
progress=Components.classes["@mozilla.org/messenger/progress;1"].createInstance(Components.interfaces.nsIMsgProgress);
2.
progress.registerListener(progress.QueryInterface(Components.interfaces.nsIWebProgressListener));

Comment 1

[alexander :surkov (:asurkov)]

I get exception: "Unhandled exception in mozilla.exe (MSGBASE.DLL): 0xC00000FD:
Stack Overflow."

Comment 2

[Boris Zbarsky [:bzbarsky]]

This has nothing to do with XPCOM.  It's just a bug in the mailnews code...  It
should throw if |this| is passed in.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

why is this not a bug in the caller, which passes a listener in which it shouldn't?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Because the callee shouldn't crash anyway....  (General "calls from JS should
not crash us" principle).

Comment 5

[Joshua Welderson]

Attachment: Proposed Patch

Requesting review.  This being the first bug I've attempted to submit, I don't
know if there's something else I'm supposed to do at this point.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 184862 [details] [diff] [review]
Proposed Patch

I'm not a mailnews peer...

also, is the call here really necessary?

Comment 7

[Joshua Welderson]

Attachment: Proposed Patch v1.1

Sorry about that... I should, in retrospect, have ensured that the comment was
done properly.	Also, I assume that pointer conversion is unnecessary in this
case.

Comment 8

[Joshua Welderson]

(In reply to comment #6)
> (From update of attachment 184862 [details] [diff] [review] [edit])
> I'm not a mailnews peer...
> 
> also, is the call here really necessary?
> 

Oh, sorry.  I didn't see your comment.  On that note, what do you mean by 'is
the call here really necessary'?  Keep in mind that I have no prior experience
in this, and as such my expertise is limited.

Comment 9

[Joshua Welderson]

Comment on attachment 184865 [details] [diff] [review]
Proposed Patch v1.1

And... fixing the requestee.  Again, I apologize.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

bah, did I write "call"? I meant to write "cast", sorry. but I see that you
already removed it :-)

Comment 11

[David :Bienvenu]

Comment on attachment 184865 [details] [diff] [review]
Proposed Patch v1.1

seems ok, thx.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 184865 [details] [diff] [review]
Proposed Patch v1.1

sr=dmose

Comment 13

[Brendan Eich [:brendan]]

Comment on attachment 184865 [details] [diff] [review]
Proposed Patch v1.1

a=me for 1.8b3.

/be

Comment 14

[timeless]

Comment on attachment 184865 [details] [diff] [review]
Proposed Patch v1.1

mozilla/mailnews/base/src/nsMsgProgress.cpp	1.20