273092 - tab captures focus when tab unselect

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041122
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041122

When I select tab then previous selected tab captures the focus.

Reproducible: Always
Steps to Reproduce:
1. create tabbox with two tabs
2. select second tab
3. select first tab

Actual Results:  
second tab captures the focus

Expected Results:  
element of first tabpanel should have focus

Comment 1

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 2

[[e-mail]]

The tabs binding changes the selected index but advanceFocusIntoSubtree thinks
that the second tab is still focusable although the tab[selected="true"] {
-moz-user-focus: normal; } rule should only apply to the first tab.

If this is difficult to fix in layout it would probably be straightfoward to
advance the focus from the tabpanels instead.

Comment 3

[Boris Zbarsky [:bzbarsky]]

So is this an issue with style changes not being applied "soon enough"?  Or
something else?  Should the focus-advancing code flush out style changes?

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev .1

Boris, you were right - this fixes it.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Mats, where's MoveFocus called from?  Could there be times when it's called from
layout (frame) code?

Comment 6

[Mats Palmgren (inactive)]

Boris, the callers of nsFocusController::MoveFocus are:

nsXULCommandDispatcher::AdvanceFocus()
nsXULCommandDispatcher::RewindFocus()
nsXULCommandDispatcher::AdvanceFocusIntoSubtree(nsIDOMElement* aElt)
nsXFormsSwitchElement::SetFocus(nsIDOMElement* aDeselected,
                               nsIDOMElement* aSelected)

which I believe means "no" to your 2nd question.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171081 [details] [diff] [review]
Patch rev .1

Ok. r+sr=bzbarsky, but make that Flush_Frames, please?	The effect will be the
same, but it'll be clearer why we're doing it (and maybe add a comment about
ensuring all frames have been constructed or something)?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171081 [details] [diff] [review]
Patch rev .1

And make it Flush_Style if we're actually going for style being up-to-date
instead of frames being up-to-date.

Comment 9

[Mats Palmgren (inactive)]

I made it Flush_Frames and added a comment. Checked in 2005-01-22 13:55 PDT.

-> FIXED