Closed Bug 273235 Opened 20 years ago Closed 20 years ago

Support XML Events also in SVG

Categories

(Core :: DOM: Events, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files, 2 obsolete files)

Attached patch fix (obsolete) — Splinter Review
Note, this does not add support for SVG 1.2 modifications to XML events. http://www.w3.org/TR/SVG12/events.html#handler-element
Attachment #167913 - Flags: superreview?(bryner)
Attachment #167913 - Flags: review?(bryner)
Shouldn't this just be automatic for all elements? Why does each namespace have to be special-cased? Does MathML need this? or HTML?
Yes, it should be "automatic" for all elements, but unfortunately we have several SetAttr() implementations. And yes, (X)HTML does have this already, so does generic XML (so XML Events do work with any XTF based elements and also with MathML).
Why mNodeinfo->GetDocument()? Why not just call GetOwnerDoc()?
Attached patch fix v2 (obsolete) — Splinter Review
Perhaps tor has time for a review.
Attachment #167913 - Attachment is obsolete: true
Attachment #171542 - Flags: review?(tor)
Attachment #167913 - Flags: superreview?(bryner)
Attachment #167913 - Flags: review?(bryner)
Attached patch this oneSplinter Review
Attachment #171542 - Attachment is obsolete: true
Attachment #171543 - Flags: review?(tor)
Comment on attachment 171540 [details] simple example This is an awesome document.
Attachment #171543 - Flags: review?(tor) → review+
Checked in. Checking in nsSVGElement.cpp; /cvsroot/mozilla/content/svg/content/src/nsSVGElement.cpp,v <-- nsSVGElement.cpp new revision: 1.71; previous revision: 1.70 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: