Closed
Bug 273311
Opened 20 years ago
Closed 19 years ago
Deleting incoming account may delete unrelated accounts if ten or more accounts exist
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tuukka.tolvanen, Assigned: tuukka.tolvanen)
References
Details
(Keywords: dataloss)
Attachments
(1 file, 1 obsolete file)
2.56 KB,
patch
|
neil
:
superreview+
|
Details | Diff | Splinter Review |
*sp3k deletes a deferred-to-global pop account in thunderbird, and sees "Would you like to subscribe to 9?" prompts and two unrelated accounts nuked in the process <sp3k> hahahaha <sp3k> no fucking way <sp3k> I deleted mail.server.server1, and it looks like it deleted mail.server.server1* *sp3k rofl <NeilAway> sp3k: oops <sp3k> probably just the prefs <sp3k> looks like it might have used the same logic for id1->id10 as well <NeilAway> yeah, that's what the code says to do :-( Didn't try to reproduce, so this is somewhat hypothetical. Steps to reproduce: 1. Create ten or more incoming accounts 2. Delete the first account 3. Restart Expected results: Only first account deleted. Actual results: Other accounts (10--19 presumably) disappear after restart as well. I deleted account1, whose identity is id1 and server is server1, so presumably those prefs should have been deleted. All account1, account10, account11, account12 (= last account), id1, id10 (= last id), server10, server11, server12 (= last server) prefs were deleted as well.
Assignee | ||
Comment 1•20 years ago
|
||
(linux thunderbird aviary 2004-12-02-11Z.)
Assignee | ||
Comment 2•20 years ago
|
||
Patch against aviary, adds trailing dot "." to root pref in nsMsgAccount/nsMsgIdentity/nsMsgIncomingServer/nsSmtpServer::ClearAllValues before handing off to nsPref::EnumerateChilren or nsPrefBranch::GetChildList. I tested that with this patch, deleting account1 drops account1.*, id1.*, server1.* prefs in my prefs. I suppose the proper fix would be for all of these to just use nsPrefBranch::DeleteBranch, which is helpful enough to take care of the dot-business at its end.
Assignee: sspitzer → t.bugz
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #167978 -
Flags: superreview?(mscott)
Attachment #167978 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 3•20 years ago
|
||
Should this make 1.0? effort - have patch risk - the current patch looks very safe to me, but then... ;) impact - low, you need to have >9 accounts and delete one severity - dataloss, but only prefs, not actual mail or such
Flags: blocking-aviary1.0?
Comment 4•20 years ago
|
||
See bug 110841 for the 'Would you like to subscribe to 9?' bug...
Comment 5•20 years ago
|
||
(In reply to comment #2) >I suppose the proper fix would be for all of these to just use >nsPrefBranch::DeleteBranch, which is helpful enough to take care of the >dot-business at its end. Not true according to prefapi.cpp which suggests that once nsIPref is finally removed from the codebase the dot will never be automatically appended.
Comment 6•20 years ago
|
||
Comment on attachment 167978 [details] [diff] [review] aviary patch0 IIRC rootPref.Append('.'); is probably preferred here. I commented in bug 226005 about the use of DeleteBranch.
Attachment #167978 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Updated•20 years ago
|
Flags: blocking-aviary1.0?
Updated•20 years ago
|
Attachment #167978 -
Flags: superreview?(mscott) → superreview?(bienvenu)
Updated•20 years ago
|
Attachment #167978 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 7•19 years ago
|
||
*** Bug 202231 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 8•19 years ago
|
||
Patch against trunk, also now appending char rather than string. nsSmtpServer.cpp uses prefbranch these days.
Attachment #167978 -
Attachment is obsolete: true
Comment 9•19 years ago
|
||
Comment on attachment 174497 [details] [diff] [review] patch against trunk Although I can't wait for the other classes to switch to pref branches too...
Attachment #174497 -
Flags: superreview+
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8b2?
Assignee | ||
Comment 10•19 years ago
|
||
checkin: http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?date=explicit&mindate=1108725420&maxdate=1108725840
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Flags: blocking1.8b2?
Resolution: --- → FIXED
Comment 11•18 years ago
|
||
*** Bug 330211 has been marked as a duplicate of this bug. ***
Comment 12•18 years ago
|
||
*** Bug 335067 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•