274703 - <dialog>s sometimes have a too small height when opened

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Stefan Borggraefe]

Follow-up bug to bug 274481.

Under certain conditions <dialog>s have a too small height when opened. This
caused bug 274481. The bug doesn't happen when I comment out the for-loop that
shows/hides buttons according to the button configuration in dialog.xml:

  for (dlgtype in buttons) 
    buttons[dlgtype].hidden = !shown[dlgtype];

Also this bug doesn't happen when very large fonts are used (see bug 274481
comment 11 and comment 12).

This bug happens with current trunk builds of FF and Seamonkey and was reported
with Windows and Linux Gtk2.

Comment 1

[[e-mail]]

Attachment: Possible patch

I don't claim that this patch is the correct way to fix the bug, but I
discovered that if I query document.documentElement.height it passes
Flush_Layout and subsequently the dialog is correctly sized.

Note that you need to back out attachment 168713 [details] [diff] [review] to test this patch.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 168963 [details] [diff] [review]
Possible patch

r=jst

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 168963 [details] [diff] [review]
Possible patch

Add a comment that this is needed because ResizeReflow won't change some sizes
that pending StyleChange reflows would...

Comment 4

[[e-mail]]

Stefan, please back out your workarounds (rs=me) before closing this bug.

Comment 5

[Stefan Borggraefe]

(In reply to comment #4)
> Stefan, please back out your workarounds (rs=me) before closing this bug.

[x] done

I also checked in the patch for bug 276894.

Marking FIXED.