Closed
Bug 275107
Opened 20 years ago
Closed 20 years ago
Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js)
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: sgautherie, Assigned: sgautherie)
Details
Attachments
(2 files)
|
2.47 KB,
patch
|
neil
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
|
2.18 KB,
patch
|
neil
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE)
{{
Warning: redeclaration of var account
Source File: chrome://messenger/content/am-server.js
Line: 186, Column: 10
Source Code:
var account = accountManager.getAccount(serverSettings.deferredToAccount);
Warning: function onOk does not always return a value
Source File: chrome://messenger/content/am-server-advanced.js
Line: 187
Source Code:
}
Warning: assignment to undeclared variable gServer
Source File: chrome://messenger/content/am-serverwithnoidentities.js
Line: 44
}}
|
Assignee | |
Comment 1•20 years ago
|
||
Neil: At first glance, I'm puzzled by the <am-serverwithnoidentities.js> case...
Assignee: sspitzer → gautheri
Target Milestone: --- → mozilla1.8alpha6
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•20 years ago
|
||
Fixes 2 of the 3 warnings, plus a (double) code optimization.
Attachment #168993 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Comment 3•20 years ago
|
||
(In reply to comment #1) >At first glance, I'm puzzled by the <am-serverwithnoidentities.js> case... That panel probably doesn't need any JavaScript to operate at all.
|
|
||
Updated•20 years ago
|
Attachment #168993 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #168993 -
Flags: superreview?(mscott)
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fixes the 3rd warning, per Neil's suggestion. Test: MailNews > Edit > M & N Account Settings... > Local Folders
Attachment #169134 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
||
Comment 5•20 years ago
|
||
Comment on attachment 169134 [details] [diff] [review] (Bv1) <am-serverwithnoidentities.js> [Checked in: Comment 10] We probably want to cvs remove the .js file too.
Attachment #169134 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #169134 -
Flags: superreview?(mscott)
|
|
Assignee | |
Updated•20 years ago
|
Flags: blocking1.8b?
Target Milestone: mozilla1.8alpha6 → mozilla1.8beta
|
|
Assignee | |
Comment 6•20 years ago
|
||
Comment on attachment 168993 [details] [diff] [review] (Av1) <am-server*.js> [Checked in: Comment 10] No super-review from <mscott@mozilla.org> since "2004-12-18" :-(
Attachment #168993 -
Flags: superreview?(mscott) → superreview?(dmose)
|
|
Assignee | |
Comment 7•20 years ago
|
||
Comment on attachment 169134 [details] [diff] [review] (Bv1) <am-serverwithnoidentities.js> [Checked in: Comment 10] No super-review from <mscott@mozilla.org> since "2004-12-19" :-(
Attachment #169134 -
Flags: superreview?(mscott) → superreview?(dmose)
|
|
Assignee | |
Updated•20 years ago
|
Summary: Some JS Strict warnings → Some JS Strict warnings (In am-server.js, am-server-advanced.js, am-serverwithnoidentities.js)
|
||
Updated•20 years ago
|
Flags: blocking1.8b? → blocking1.8b-
|
||
Comment 8•20 years ago
|
||
Comment on attachment 169134 [details] [diff] [review] (Bv1) <am-serverwithnoidentities.js> [Checked in: Comment 10] sr=dmose
Attachment #169134 -
Flags: superreview?(dmose) → superreview+
|
|
||
Comment 9•20 years ago
|
||
Comment on attachment 168993 [details] [diff] [review] (Av1) <am-server*.js> [Checked in: Comment 10] sr=dmose
Attachment #168993 -
Flags: superreview?(dmose) → superreview+
|
|
||
Comment 10•20 years ago
|
||
Fixes checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•20 years ago
|
Attachment #168993 -
Attachment description: (Av1) <am-server*.js> → (Av1) <am-server*.js>
[Checked in: Comment 10]
Attachment #168993 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•20 years ago
|
Attachment #169134 -
Attachment description: (Bv1) <am-serverwithnoidentities.js> → (Bv1) <am-serverwithnoidentities.js>
[Checked in: Comment 10]
Attachment #169134 -
Attachment is obsolete: true
|
||
Updated•19 years ago
|
Attachment #168993 -
Attachment is obsolete: false
|
|
||
Updated•19 years ago
|
Attachment #169134 -
Attachment is obsolete: false
|
||
Comment 11•19 years ago
|
||
It looks like these warning fixes caused Bug 308311. gServer is no longer getting defined for local folders in amUtils.js because it was getting defined in am-serverwithnoidentities.js.
You need to log in
before you can comment on or make changes to this bug.
Description
•