275139 - [FIXr]Dynamic changes of border-style don't cause reflow

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   1. Change a "border-style" property from 'none' to 'solid.

ACTUAL RESULTS
   Not much.

EXPECTED RESULTS
   Reflow.

TESTCASES
   http://www.hixie.ch/tests/adhoc/css/border/dynamic/001.html
   http://www.hixie.ch/tests/adhoc/css/border/dynamic/002.html

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

The first hunk is not strictly needed for this bug, but I had it in my tree
anyway (maybe as a fix to some other bug whose patch has been forgotten?)... it
seems like a more correct setup for the default values in the struct.

The second hunk is what fixes this bug.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 171666 [details] [diff] [review]
Patch

r+sr=dbaron on the second chunk; please file a separate bug on the first -- I'm
not prepared to try to understand all that code right now

Comment 3

[Bernd]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsStyleStruct.cpp&branch=&root=/cvsroot&subdir=mozilla/layout/style&command=DIFF_FRAMESET&rev1=3.72&rev2=3.73
is from bug 4510 seems similiar

Comment 4

[Boris Zbarsky [:bzbarsky]]

Second hunk checked in.  Bug 279156 filed on the first hunk.