Closed
Bug 275532
Opened 20 years ago
Closed 20 years ago
Don't expose STATE_SELECTED for text objects
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access)
Attachments
(1 file)
1.64 KB,
patch
|
Louie.Zhao
:
review+
Henry.Jia
:
superreview+
|
Details | Diff | Splinter Review |
The STATE_SELECTED state is intended to be used with selected choices in
widgets, such as list or tree items.
Right now we calculate whether the selection is currently in a text object for
each text object in the tree, which only slows us down.
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #169286 -
Flags: superreview?(Henry.Jia)
Attachment #169286 -
Flags: review?(Louie.Zhao)
Comment 2•20 years ago
|
||
Comment on attachment 169286 [details] [diff] [review]
Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState()
This patch is ok. From the definition and real experience working with AT-Tools
on Unix, STATE_SELECTED/SELECTABLE is not needed for Text object.
One minor thing:
>@@ -80,32 +80,10 @@ NS_IMETHODIMP nsHTMLTextAccessible::GetS
> nsCOMPtr<nsIPresShell> shell(GetPresShell());
> if (!shell) {
> return NS_ERROR_FAILURE;
> }
These 3 lines can also be deleted since it's useless.
Attachment #169286 -
Flags: review?(Louie.Zhao) → review+
Assignee | ||
Comment 3•20 years ago
|
||
Thanks Louie.
Comment on attachment 169286 [details] [diff] [review]
Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState()
sr=Henry
Attachment #169286 -
Flags: superreview?(Henry.Jia) → superreview+
Assignee | ||
Comment 5•20 years ago
|
||
Checking in nsHTMLTextAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHTMLTextAccessible.cpp,v <--
nsHTMLTextAccessible.cpp
new revision: 1.39; previous revision: 1.38
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•