Closed Bug 275532 Opened 20 years ago Closed 20 years ago

Don't expose STATE_SELECTED for text objects

Categories

(Core :: Disability Access APIs, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access)

Attachments

(1 file)

The STATE_SELECTED state is intended to be used with selected choices in widgets, such as list or tree items. Right now we calculate whether the selection is currently in a text object for each text object in the tree, which only slows us down.
Attachment #169286 - Flags: superreview?(Henry.Jia)
Attachment #169286 - Flags: review?(Louie.Zhao)
Comment on attachment 169286 [details] [diff] [review] Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState() This patch is ok. From the definition and real experience working with AT-Tools on Unix, STATE_SELECTED/SELECTABLE is not needed for Text object. One minor thing: >@@ -80,32 +80,10 @@ NS_IMETHODIMP nsHTMLTextAccessible::GetS > nsCOMPtr<nsIPresShell> shell(GetPresShell()); > if (!shell) { > return NS_ERROR_FAILURE; > } These 3 lines can also be deleted since it's useless.
Attachment #169286 - Flags: review?(Louie.Zhao) → review+
Thanks Louie.
Comment on attachment 169286 [details] [diff] [review] Remove STATE_SELECTABLE/STATE_SELECTED calculation from nsHTMLTextAccessible::GetState() sr=Henry
Attachment #169286 - Flags: superreview?(Henry.Jia) → superreview+
Checking in nsHTMLTextAccessible.cpp; /cvsroot/mozilla/accessible/src/html/nsHTMLTextAccessible.cpp,v <-- nsHTMLTextAccessible.cpp new revision: 1.39; previous revision: 1.38 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: