276840 - Move $::defaultqueryname out of globals.pl into Bugzilla/Constants.pm

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

I was thinking of moving $::defaultqueryname out of globals.pl and probably into
Bugzilla::Constants. It should be a pretty simple, easy change.

I was considering also putting it in Bugzilla::Search, but it's a constant, so
it should probably go into Constants.

Comment 1

[Max Kanat-Alexander]

Attachment: Patch against the tip

OK, here's a patch that makes these very simple changes. The only pages that
use this var are buglist.cgi and query.cgi.

Comment 2

[Vlad Dascalu]

Comment on attachment 170122 [details] [diff] [review]
Patch against the tip

In addition to moving this to Bugzilla/Constants.pm, this also fixes some
quoting bugs by passing to SendSQL correctly quoted values instead of unquoted
ones.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 170122 [details] [diff] [review]
Patch against the tip

>@@ -391,7 +391,7 @@
> if ($userid) {
>     my @namedqueries;
>     SendSQL("SELECT name FROM namedqueries " .
>-            "WHERE userid = $userid AND name != '$::defaultqueryname' " .
>+            "WHERE userid = $userid AND name != " SqlQuote(DEFAULT_QUERY_NAME) .
>             "ORDER BY name");

  Slight bug here, though, that should be fixed on check-in. That line should
be:

+	     "WHERE userid = $userid AND name != " .
SqlQuote(DEFAULT_QUERY_NAME) .

  Note the added ".".

  I don't know how that slipped by me.

Comment 4

[Max Kanat-Alexander]

Attachment: Version 1.1 (Fixed bitrot and slight error)

This is the version that should actually be checked-in.

Comment 5

[Shane H. W. Travis]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.271; previous revision: 1.270
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.285; previous revision: 1.284
done
Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.136; previous revision: 1.135
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.15; previous revision: 1.14
done