277013 - voting generates an SQL error if your vote is the one that would confirm the bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

If you vote for a bug and the total number of votes becomes high enough to
confirm that bug, a SQL error is generated because of LOCK TABLE. This is due to
CheckIfVotedConfirmed() which should be outside the LOCK TABLE and UNLOCK TABLE.

My patch in bug 276605 will fix it.

This problem appears in both 2.18 and the trunk.

Comment 1

[Frédéric Buclin]

Attachment: fix the SQL error, v1

Because Dave and Marc prefer this solution, I finally splitted my patch in bug
276605 into two distinct parts. Here is the one about the SQL error only.

Comment 2

[Frédéric Buclin]

*Note* I wrote this patch with Vlad's patch from bug 276600 already checked in.
So his patch has to land before mine.

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 170460 [details] [diff] [review]
fix the SQL error, v1

Ok, this is it :)

Let's keep the hackiness of header_done :/

As discussed on IRC, there are a couple of tables missing when supportwatchers
is on. These are

   profiles AS watchers READ
   profiles AS watched READ
   watch READ

Please add these and carry r+ forward. We'll need to wait for bug 276600 then.

Whew.

[On a related note, it is indeed possible to print $cgi->header() more than
once (see bug 276605, comment 6) -- CGI::header keeps track of having been
called. So that worry is off my chest.]

Comment 4

[Frédéric Buclin]

Attachment: fix the SQL error, v2

Adding missing watch, watchers and watched tables, per Marc's previous comment.
Forwarding r+ too.

Comment 5

[Frédéric Buclin]

This patch applies cleanly to the trunk and the 2.18 branch.

Comment 6

[Vlad Dascalu]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.221; previous revision: 1.220
done
Checking in votes.cgi;
/cvsroot/mozilla/webtools/bugzilla/votes.cgi,v  <--  votes.cgi
new revision: 1.21; previous revision: 1.20
done
Checking in template/en/default/bug/votes/list-for-user.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-user.html.tmpl,v
 <--  list-for-user.html.tmpl
new revision: 1.16; previous revision: 1.15
done

Comment 7

[Vlad Dascalu]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.211.2.7; previous revision: 1.211.2.6
done
Checking in votes.cgi;
/cvsroot/mozilla/webtools/bugzilla/votes.cgi,v  <--  votes.cgi
new revision: 1.17.2.1; previous revision: 1.17
done
Checking in template/en/default/bug/votes/list-for-user.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/votes/list-for-user.html.tmpl,v
 <--  list-for-user.html.tmpl
new revision: 1.15.2.1; previous revision: 1.15
done

Comment 8

[Frédéric Buclin]

*** Bug 300215 has been marked as a duplicate of this bug. ***