Closed
Bug 277329
Opened 20 years ago
Closed 20 years ago
nsIMenu.h need not include nsIDocShell.h
Categories
(Core Graveyard :: GFX, defect)
Core Graveyard
GFX
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
References
()
Details
Attachments
(1 file)
|
632 bytes,
patch
|
roc
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsIDocShell is only used as an argument, as a pointer. hence, a forward
declaration should suffice:
class nsIDocShell;
|
||
Comment 1•20 years ago
|
||
biesi, is this just a one-line change? Wanna post a patch?
|
Assignee | |
Comment 2•20 years ago
|
||
when I filed the bug, I weren't sure if other files depended on this file
including nsIDocShell.h
it seems no files do, at least on linux.
Assignee: general → cbiesinger
Status: NEW → ASSIGNED
Attachment #172918 -
Flags: superreview?(bzbarsky)
Attachment #172918 -
Flags: review?(roc)
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 172918 [details] [diff] [review]
patch
sr=bzbarsky if you do forward-declare nsIDocShell... (mac will need that, I'm
sure).
Attachment #172918 -
Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 172918 [details] [diff] [review]
patch
what bz said
Attachment #172918 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Checking in widget/public/nsIMenu.h;
/cvsroot/mozilla/widget/public/nsIMenu.h,v <-- nsIMenu.h
new revision: 1.31; previous revision: 1.30
done
(with forward-declaration of nsIDocShell)
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•