Closed
Bug 277599
Opened 20 years ago
Closed 20 years ago
embedprompter should wrap text in the check box
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: chpe)
References
()
Details
Attachments
(2 files)
1.23 KB,
patch
|
mpgritti
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
28.72 KB,
image/png
|
Details |
EmbedPrompter doesn't wrap the text in the check box label. That leads to abominations such as this one: http://www.cs.vu.nl/~reinout/Veiligheidswaarschuwing.png
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #170703 -
Flags: review?(marco)
Assignee | ||
Comment 2•20 years ago
|
||
Comment 3•20 years ago
|
||
Comment on attachment 170703 [details] [diff] [review] enable line wrapping in the label The visual result is not yet optimal (probably check boxes labels should not be that long in first place) but it's way better and it make sense to wrap the checkbox text since we are wrapping the message text.
Attachment #170703 -
Flags: review?(marco) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #170703 -
Flags: superreview?(blizzard)
Updated•20 years ago
|
Attachment #170703 -
Flags: superreview?(blizzard) → superreview+
Updated•20 years ago
|
Assignee: blizzard → chpe
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•20 years ago
|
||
I checked this patch in: Checking in embedding/browser/gtk/src/EmbedPrompter.cpp; /cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.cpp,v <-- EmbedPrompter.cpp new revision: 1.15; previous revision: 1.14 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•