277627 - make openCacheEntry take an ACString parameter instead of string

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Brian Ryner (not reading)]

This makes things just a bit more efficient (avoid a length calculation),
especially since almost all of the callers already have an nsACString.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 170724 [details] [diff] [review]
patch

don't forget nsICacheEntryInfo::key :-)

also, the cache key is not required to conform to any character encoding.  it
was designed to be any null-terminated byte array.  that said, i think it is
probably a safe assumption that all consumers pass UTF-8 (if non-ASCII).

for a while, i've wanted to fix all of the cache interfaces to use the string
classes instead.

Comment 3

[Brian Ryner (not reading)]

No need to enforce UTF8 now then, I'll just use ACString.

Comment 4

[Brian Ryner (not reading)]

Attachment: revised patch

Comment 5

[Darin Fisher]

Comment on attachment 170762 [details] [diff] [review]
revised patch

I would really like to see the rest of the |string|'s in the cache API switched
over too, but that can wait.  Thanks for the patch!

Comment 6

[Brian Ryner (not reading)]

checked in.