277657 - (Xpfe) textbox.maxLength doesn't work

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:

1. XUL: <textbox id="myTextbox" />
2. JS: document.getElementbyId("myTextbox").maxLength = 20;
3. Run, enter 30 characters in myTextbox.

Actual result:
Can enter 200 and more characters

Expected result:
Input stops working after 20 characters

Reason:
Case problem in code in xpfe/global/.

Attaching patch.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Fix, v1

Comment 2

[[e-mail]]

Comment on attachment 170736 [details] [diff] [review]
Fix, v1

Heh, I see aaronlev managed to fix the name of the xbl property but overlooked
the name on the input field.

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 170736 [details] [diff] [review]
Fix, v1

a=asa for checkin to 1.8a6

Comment 4

[Ben Bucksch (:BenB)]

checked into trunk

Comment 5

[Steffen Wilberg]

Shouldn't this be fixed in toolkit's textbox.xml as well?
http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/textbox.xml#50

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 170736 [details] [diff] [review]
Fix, v1

a=mkaply for 1.7.6

Comment 7

[Ben Bucksch (:BenB)]

checked into 1.7 branch.

Comment 8

[alexander :surkov (:asurkov)]

As I know when property 'maxLength' of html:input is chnaged then attribute
'maxlength' is changed too. By anology with html:input we can change property
'maxLength' of textbox. It can be look like:

<property name="maxLength"  onset="this.setAttribute('maxlength', val); return val;"
                            onget="return this.getAttribute('maxlength');"/>

Comment 9

[Boris Zbarsky [:bzbarsky]]

Mike, could you fix toolkit too?

Comment 10

[Boris Zbarsky [:bzbarsky]]

I filed bug 280485 on the toolkit version of this.

Comment 11

[Daniel Veditz [:dveditz]]

Please add the appropriate "fixed" keywords when checking into a branch.