277686 - [FIX]Bug in :target when combined with :first-letter and text-transform

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[tom sherman]

The URL above has a full description and demonstration of the bug.  When an
element, e.g. H1, has :first-letter and text-transform applied to it, it
functions normally.

However, when a child element is styled via the :target pseudo-class applied to
that element, the parent element loses its :first-letter styling, and the
ordering of the text within the parent element is incorrect.

I have not verified if this behavior extends beyond text-transform with
:first-letter and :target with a child element.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Reporter's testcase

Comment 2

[Mats Palmgren (inactive)]

Confirming bug, 2001-01-06-05 trunk Linux.  In a debug build I see:

###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file
nsBlockFrame.cpp, line 5014

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

The basic problem is that ContentInserted() uses the prevSibling to decide
where to insert, and RemoveLetterFrames will sometimes remove (and destroy) the
prevSibling.   So we end up inserting at the front of the frame list instead of
in the right spot.  Just regetting the prevSibling after RemoveLetterFrames
helps.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.