277839 - Implement /notice command

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[Oren Shahar]

The /notice should echo back and show you the messege that was sent, similarly
to the /msg command. As of now, there is no reminder or notification that you
sent the /notice.

Comment 1

[James Ross]

/notice does not exist. What you really want is to get /notice implemented.

Comment 2

[Oren Shahar]

(In reply to comment #1)
> /notice does not exist. What you really want is to get /notice implemented.

Heh, oops. I assumed since I've never had trouble in using it in any of the
servers I'm on it was a standard command. My mistake.

Comment 3

[:Gijs (he/him)]

Attachment: Patch based on cmdMsg

I figured this could be done the same way /msg is handled, and I turned out to
be right, it seems.

I removed all the second parameters to .say, which were redundant. They were
there because rginda didn't remove them when switching all text encoding
handling to the irc library. (the calls used to be like:
user.say(fromUnicode(msg, e.sourceObject)) )

requesting review from Samuel Sieb :-)

Comment 4

[Samuel Sieb]

Comment on attachment 176045 [details] [diff] [review]
Patch based on cmdMsg

in the .properties file in the line:
cmd.notice.help   = Sends a notice <msg> to <nickname>
<msg> should be <message> to match the params

Comment 5

[:Gijs (he/him)]

Attachment: updated help messages

Updated both the help messages of /notice and of /msg, since both had <msg>
instead of <message>.

Comment 6

[James Ross]

Checked in --> FIXED.

In approximately 41 minutes a build with this fix will be available from:
 http://twpol.dyndns.org/mozilla/chatzilla/nightly/