Closed
Bug 278051
Opened 20 years ago
Closed 20 years ago
remove quotes from embedding modules macros
Categories
(Core Graveyard :: Embedding: Packaging, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: csthomas)
References
()
Details
Attachments
(1 file)
1.32 KB,
patch
|
zack
:
review+
csthomas
:
superreview+
|
Details | Diff | Splinter Review |
/embedding/lite/nsEmbedLiteModule.cpp, line 68 -- NS_IMPL_NSGETMODULE("EmbedLite components", components) /embedding/browser/qt/src/EmbedModules.cpp, line 55 -- NS_IMPL_NSGETMODULE("Qt components", components) I think using '_' instead of ' ' would be in keeping with most of the other embedding components...
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #171939 -
Flags: review?(locka)
Assignee | ||
Updated•20 years ago
|
Whiteboard: [cst: r?]
Assignee | ||
Updated•20 years ago
|
Attachment #171939 -
Flags: review?(locka) → review?(zack)
Assignee | ||
Updated•20 years ago
|
Attachment #171939 -
Flags: superreview?(alecf)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Comment 2•20 years ago
|
||
Comment on attachment 171939 [details] [diff] [review] patch sr=alecf
Attachment #171939 -
Flags: superreview?(alecf) → superreview+
Updated•20 years ago
|
Attachment #171939 -
Flags: superreview?(alecf)
Attachment #171939 -
Flags: superreview+
Attachment #171939 -
Flags: review?(zack)
Attachment #171939 -
Flags: review+
Assignee | ||
Updated•20 years ago
|
Whiteboard: [cst: r?] → checkin
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 171939 [details] [diff] [review] patch resetting sr=alecf
Attachment #171939 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 4•20 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: checkin
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•