Closed
Bug 278201
Opened 21 years ago
Closed 21 years ago
infinite loop in use tag hangs svg renderer
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jvdoever, Assigned: tor)
Details
Attachments
(1 file, 1 obsolete file)
|
1.05 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
View an image with specified svg content in mozilla.
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink">
<defs>
<g id="1">
<use xlink:href="#1" x="0" y="0"/>
</g>
</defs>
</svg>
|
||
Comment 2•21 years ago
|
||
Comment on attachment 171786 [details] [diff] [review]
circular loop detection
Any reason not to do
if (nsContentUtils::ContentIsDescendantOf(this, targetContent)) {
return NS_ERROR_FAILURE;
}
?
Attachment #171786 -
Attachment is obsolete: true
Attachment #171786 -
Flags: review?(bzbarsky)
The usual - ignorance that such a utility function existed.
Attachment #171792 -
Flags: review?(bzbarsky)
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 171792 [details] [diff] [review]
using nsContentUtils::ContentIsDescendantOf
r+sr=bzbarsky
Attachment #171792 -
Flags: superreview+
Attachment #171792 -
Flags: review?(bzbarsky)
Attachment #171792 -
Flags: review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
The infinite recursion is fixed. Shouldn't the renderer be more verbose about
it? Right now, only an empty page is shown without any reason.
|
|
||
Comment 7•21 years ago
|
||
Probably, but that's a separate bug. Feel free to file it and CC me. :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•