278201 - infinite loop in use tag hangs svg renderer

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[jvdoever]

View an image with specified svg content in mozilla.

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg xmlns="http://www.w3.org/2000/svg"
     xmlns:xlink="http://www.w3.org/1999/xlink">
 <defs>
  <g id="1">
   <use xlink:href="#1" x="0" y="0"/>
  </g>
 </defs>
</svg>

Comment 1

[tor]

Attachment: circular loop detection

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171786 [details] [diff] [review]
circular loop detection

Any reason not to do

if (nsContentUtils::ContentIsDescendantOf(this, targetContent)) {
  return NS_ERROR_FAILURE;
}

?

Comment 3

[tor]

Attachment: using nsContentUtils::ContentIsDescendantOf

The usual - ignorance that such a utility function existed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 171792 [details] [diff] [review]
using nsContentUtils::ContentIsDescendantOf

r+sr=bzbarsky

Comment 5

[tor]

Checked in.

Comment 6

[jvdoever]

The infinite recursion is fixed. Shouldn't the renderer be more verbose about
it? Right now, only an empty page is shown without any reason.

Comment 7

[Jonathan Watt [:jwatt]]

Probably, but that's a separate bug. Feel free to file it and CC me. :-)