278202 - Select won't update properly if bound node changes

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

using patch to 265467 I found that a select element won't be properly updated
via nsXFormsSelectElement::Refresh().  Even though all of the items are removed
and re-inserted into mSelect, it seems to remember the selected items.  So if a
new value is given via another control to instance data that is also bound to
the select control, the old value that was selected will stay selected and the
new value will also be selected.  I have a testcase and a fix.  Just need to set
the selected index to -1 after mSelect is populated and before the mSelect is
re-sync'd with the bound node.

Comment 1

[aaronr]

Attachment: testcase that shows problem

Type "Vanilla Chocolate" in the textfield then hit the TAB key, it should
select both elements.  Then type "Chocolate" in the textfied and hit the TAB
key.  That should cause only Chocolate to be selected.

Comment 2

[aaronr]

Attachment: proposed fix

proposed fix

Comment 3

[Allan Beaufour]

Attachment: testcase without mdg dependency

Aarons testcase depends on the MDG patch in bug 265467. Here's one where you
can manually emit xforms-refresh events after changing values.

Comment 4

[Allan Beaufour]

Comment on attachment 171116 [details] [diff] [review]
proposed fix

r=me

Comment 5

[aaronr]

bryner checked in fix for me 01/16