278811 - Stack overflow in mail client while checking for new POP mail

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Andrei]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050111
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050111

I have experienced multiple times crashes in the mail client while
checking/receiving mail. The last time my debugger reported a stack overflow.

I have quick launch activated.
I usually have one or several browser windows open when the crash occurs.


Reproducible: Sometimes

Comment 1

[Frank Wein [:mcsmurf]]

Can you provide a talkback id (start components/talkback.exe in your Mozilla
folder after sending the talkback incident)?

Comment 2

[Andrei]

(In reply to comment #1)
> Can you provide a talkback id (start components/talkback.exe in your Mozilla
> folder after sending the talkback incident)?

I did what you suggested and -> TB3135104H

Comment 3

[David :Bienvenu]

the view manager seems to be recursing infinitely - here are a couple iterations
from the stack trace:

GDI32.dll + 0x58ec (0x7f0058ec)
GDI32.dll + 0x5839 (0x7f005839)
nsDrawingSurfaceWin::Init 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/gfx/src/windows/nsDrawingSurfaceWin.cpp,
line 451]
nsRenderingContextWin::CreateDrawingSurface 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/gfx/src/windows/nsRenderingContextWin.cpp,
line 1020]
nsViewManager::RenderViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1344]
nsViewManager::Refresh 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 945]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1102]
nsWindow::Invalidate 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 2662]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1774]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1825]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1650]
nsViewManager::UpdateViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1858]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1102]
nsWindow::Invalidate 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 2662]
nsViewManager::UpdateWidgetArea 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1774]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1825]
nsViewManager::UpdateView 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1650]
nsViewManager::UpdateViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1858]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]

Comment 4

[timeless]

*** Bug 279127 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

So I don't understand on thing here... This part of the stack:

nsViewManager::UpdateViews 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1858]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 1946]

There is no call to UpdateViews in DispatchEvent (either now, or on Jan 11,
which is when that build is from).  There's nothing remotely like DispatchEvent
on line 1946.

The only place I can sort of see us recursing is if we end up in the
mRecursiveRefreshPending thing while handling a sync paint.  We'll trigger
UpdateAllViews with a sync paint, and recurse sort of like this (with a
different callstack, though...)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: This may help...

roc, what do you think?

Comment 7

[Boris Zbarsky [:bzbarsky]]

I checked in the patch.  Could someone who could reproduce the bug retest with
tomorrow's builds?

Comment 8

[Anthony Howe]

(In reply to comment #5)
> So I don't understand on thing here... This part of the stack:
> 
> nsViewManager::UpdateViews 
>
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
> line 1858]
> nsViewManager::DispatchEvent 
>
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
> line 1946]

Is this not related to the little "biff" pop-up that notifies you of when mail
arrives as I mentioned in 279127 and 279804?

Comment 9

[Boris Zbarsky [:bzbarsky]]

OK, going to mark this fixed, per comments in bug 279804.