279012 - no support for @incremental in input, et. al.

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

We currently have no support for the incremental attribute for our input, secret
and textarea controls.

Which isn't a massively huge deal since neither does Novell or XSmiles as far as
I can tell.  But formsPlayer does and we will need to eventually.

I will post a testcase.

Comment 1

[aaronr]

Attachment: testcase that shows the problem

testcase that will show the problem for xforms:input control

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

It is on purpose to not to set the event handled=true in handleDefault.

Comment 3

[Allan Beaufour]

Comment on attachment 172799 [details] [diff] [review]
v1

>Index: nsXFormsInputElement.cpp
>===================================================================
>+++ nsXFormsInputElement.cpp	29 Jan 2005 13:00:39 -0000
...
> nsXFormsInputElement::OnCreated(nsIXTFXMLVisualWrapper *aWrapper)
> {
>   nsresult rv = nsXFormsControlStub::OnCreated(aWrapper);
>   NS_ENSURE_SUCCESS(rv, rv);
> 
>+  mIncremental = PR_FALSE;
>+

Do put this in the constructor.

>+nsresult
>+nsXFormsInputElement::UpdateInstanceData()
...
>+      // Dispatching xforms-value-changed between xforms-revalidate
>+      // and xforms-refresh
>+      // @see http://www.w3.org/TR/xforms/slice4.html#rpm-event-seq-vcwfc
>+      rv = nsXFormsUtils::DispatchEvent(mElement, eEvent_ValueChanged);
>+      NS_ENSURE_SUCCESS(rv, rv);
>+      

The model does this for you already, so you do not need it.

With the above two changes, r=me.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1 + comments

Comment 5

[Brian Ryner (not reading)]

checked in