279176 - Delete Mail List in Addressbook Sidebar doesn't work

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Mark Banner (:standard8)]

When I start up the browser, go to the addressbook sidebar select a mailing
list, and then select delete from the context menu, nothing happens and the
following error appears on the console.

JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 361:
gAddressBookBundle has no properties

gAddressBookBundle is defined in several places throughout the address book
javascript code, and initialised locally in those places. I could just try and
fix this instance, however a better fix would be to move any global variables
(that are used across more than one file) to abCommon.js and initialise them all
once via abCommon.js in the InitCommonJS with a flag to only initalise them once.

When the various pages load that require the address book, they can just call
InitCommonJS (as a lot of them do already)

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Actually, I get this exception:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://communicator/content/sidebar/sidebarOverlay.js :: SidebarTogglePanel ::
line 1290"  data: no]

Comment 2

[Mark Banner (:standard8)]

Attachment: Patch to fix

This patch fixes the sidebar problem and creates just one version of the
gAddressBookBundle variable.

I'm not doing the slightly more reorganisation as I said I might as it turns
out it didn't work in the way I thought it did.

Comment 3

[Mark Banner (:standard8)]

I forgot to mention: we'll checkout stephen's problem again after this patch
goes in. I'm not sure if it's related.

Comment 4

[David :Bienvenu]

Comment on attachment 176622 [details] [diff] [review]
Patch to fix

does this affect thunderbird, or are all these files forked or all not forked?

Comment 5

[Mark Banner (:standard8)]

Dropping the "(reorganise global variables)" from the summary as it wasn't
necessary to happen.

In response to David's comments, I believe all the files are either forked or
not used by thunderbird. Additionally, I've checked that the thunderbird build
does still work with these changes. Thunderbird was also working in the first
place, this bug only existed in mailnews.

Comment 6

[Mark Banner (:standard8)]

timeless checked these in:

2005-03-09 12:23	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ resources/
content/ addressbook-panel.xul 	1.21 	4/0
2005-03-09 12:23	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ resources/
content/ abSelectAddressesDialog.js 	1.40 	2/4 
2005-03-09 12:23	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ resources/
content/ abMailListDialog.js 	1.42 	3/5 
2005-03-09 12:23	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ resources/
content/ abCommon.js 	1.100 	2/0 
2005-03-09 12:23	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ resources/
content/ abCardOverlay.js 	1.54 	1/2 
2005-03-09 12:23	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ resources/
content/ addressbook.js 	1.113 	0/2

Marking as fixed, stephen if you're still getting problems, chat with me on irc
or reopen, but I'm not convinced they are as a result of the addressbook code.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

My problem seems fixed.  Successfully deleted several mailing lists in the
Address Book sidebar.

Verified FIXED using 2005-03-11-05 on Windows XP Seamonke trunk.